[[ Cleanup ]] Correct use of MCArray ops in bitmap effects and gradients

runrevmark · runrevmark · commit e7178dcc3837 · 2017-09-06T17:51:16.000+01:00
This patch corrects the use of MCArrayFetch/Store value in the bitmap
effect and gradient set/get property functions. Previously they were
using kMCCompareExact as the argument to 'case_sensitive'. This has
been replaced with ctxt.GetCaseSensitive().
diff --git a/engine/src/bitmapeffect.cpp b/engine/src/bitmapeffect.cpp
@@ -706,7 +706,7 @@ bool MCBitmapEffectsGetProperty(MCExecContext& ctxt, MCBitmapEffectsRef& self, M
                     // Fetch the property, then store it into the array.
                     MCBitmapEffectFetchProperty(ctxt, t_effect, s_bitmap_effect_properties[i] . value, t_value);
                     MCExecTypeConvertAndReleaseAlways(ctxt, t_value . type, &t_value , kMCExecValueTypeValueRef, &(&t_valueref));
-                    MCArrayStoreValue(*v, ctxt . GetCaseSensitive(), MCNAME(s_bitmap_effect_properties[i] . token), *t_valueref);
+                    MCArrayStoreValue(*v, false, MCNAME(s_bitmap_effect_properties[i] . token), *t_valueref);
                 }
             }
             r_value . arrayref_value = MCValueRetain(*v);
@@ -1021,7 +1021,7 @@ bool MCBitmapEffectsSetProperty(MCExecContext& ctxt, MCBitmapEffectsRef& self, M
                 MCValueRef t_prop_value;
                 
                 // If we don't have the given element, then move to the next one
-                if (!MCArrayFetchValue(*t_array, kMCCompareExact, MCNAME(s_bitmap_effect_properties[i] . token), t_prop_value))
+                if (!MCArrayFetchValue(*t_array, false, MCNAME(s_bitmap_effect_properties[i] . token), t_prop_value))
                     continue;
                 
                 // Otherwise, fetch the keys value and attempt to set the property
diff --git a/engine/src/gradient.cpp b/engine/src/gradient.cpp
@@ -253,7 +253,7 @@ bool MCGradientFillGetProperties(MCExecContext& ctxt, MCGradientFill* p_gradient
             t_success = !ctxt . HasError();
         }
         if (t_success)
-            t_success = MCArrayStoreValue(*v, kMCCompareExact, MCNAME(gradientprops[tablesize].token), t_prop_value);
+            t_success = MCArrayStoreValue(*v, false, MCNAME(gradientprops[tablesize].token), t_prop_value);
     }
     
     MCerrorlock--;
@@ -523,7 +523,7 @@ bool MCGradientFillSetProperties(MCExecContext& ctxt, MCGradientFill*& x_gradien
             {
                 MCValueRef t_prop_value;
                 
-                if (MCArrayFetchValue(*t_array, kMCCompareExact, MCNAME(gradientprops[tablesize].token), t_prop_value))
+                if (MCArrayFetchValue(*t_array, false, MCNAME(gradientprops[tablesize].token), t_prop_value))
                 {
                     MCExecValue t_value;
                     t_value . valueref_value = MCValueRetain(t_prop_value);

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,7 @@ bool MCGradientFillGetProperties(MCExecContext& ctxt, MCGradientFill* p_gradient`
`253`	`253`	`t_success = !ctxt . HasError();`
`254`	`254`	`}`
`255`	`255`	`if (t_success)`
`256`		`- t_success = MCArrayStoreValue(*v, kMCCompareExact, MCNAME(gradientprops[tablesize].token), t_prop_value);`
	`256`	`+ t_success = MCArrayStoreValue(*v, false, MCNAME(gradientprops[tablesize].token), t_prop_value);`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`MCerrorlock--;`
`@@ -523,7 +523,7 @@ bool MCGradientFillSetProperties(MCExecContext& ctxt, MCGradientFill*& x_gradien`
`523`	`523`	`{`
`524`	`524`	`MCValueRef t_prop_value;`
`525`	`525`
`526`		`- if (MCArrayFetchValue(*t_array, kMCCompareExact, MCNAME(gradientprops[tablesize].token), t_prop_value))`
	`526`	`+ if (MCArrayFetchValue(*t_array, false, MCNAME(gradientprops[tablesize].token), t_prop_value))`
`527`	`527`	`{`
`528`	`528`	`MCExecValue t_value;`
`529`	`529`	`t_value . valueref_value = MCValueRetain(t_prop_value);`