[Bug 17361] Ensure <mobileControlDo "myInput", "focus"> works on Android

livecodepanos · livecodepanos · commit f7fc3dc84d00 · 2020-02-06T13:18:27.000+02:00
diff --git a/docs/notes/bugfix-17361.md b/docs/notes/bugfix-17361.md
@@ -0,0 +1 @@
+# Ensure `mobileControlDo "myinput", "focus"` works on Android
diff --git a/engine/src/java/com/runrev/android/nativecontrol/InputControl.java b/engine/src/java/com/runrev/android/nativecontrol/InputControl.java
@@ -315,6 +315,14 @@ public int getSelectedRangeLength()
     public void focusControl()
     {
         m_text_view.requestFocus();
+        
+        InputMethodManager imm;
+        imm = (InputMethodManager) m_text_view.getContext().getSystemService(Context.INPUT_METHOD_SERVICE);
+        
+        if (imm != null)
+            imm.restartInput(m_text_view);
+        
+        imm.showSoftInput(m_text_view, InputMethodManager.SHOW_IMPLICIT);
     }
     
     public native void doBeginEditing();
diff --git a/engine/src/mblandroidinput.cpp b/engine/src/mblandroidinput.cpp
@@ -285,13 +285,14 @@ MCObjectPropertyTable MCAndroidInputControl::kPropertyTable =
 
 MCNativeControlActionInfo MCAndroidInputControl::kActions[] =
 {
+    DEFINE_CTRL_EXEC_METHOD(Focus, Void, MCAndroidInputControl, Focus)
 };
 
 MCNativeControlActionTable MCAndroidInputControl::kActionTable =
 {
     &MCAndroidControl::kActionTable,
-    0,
-    nil,
+    sizeof(kActions) / sizeof(kActions[0]),
+    &kActions[0],
 };
 
 ////////////////////////////////////////////////////////////////////////////////

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+# Ensure `mobileControlDo "myinput", "focus"` works on Android
Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,14 @@ public int getSelectedRangeLength()`
`315`	`315`	`public void focusControl()`
`316`	`316`	`{`
`317`	`317`	`m_text_view.requestFocus();`
	`318`	`+`
	`319`	`+ InputMethodManager imm;`
	`320`	`+ imm = (InputMethodManager) m_text_view.getContext().getSystemService(Context.INPUT_METHOD_SERVICE);`
	`321`	`+`
	`322`	`+ if (imm != null)`
	`323`	`+ imm.restartInput(m_text_view);`
	`324`	`+`
	`325`	`+ imm.showSoftInput(m_text_view, InputMethodManager.SHOW_IMPLICIT);`
`318`	`326`	`}`
`319`	`327`
`320`	`328`	`public native void doBeginEditing();`
Original file line number	Diff line number	Diff line change
`@@ -285,13 +285,14 @@ MCObjectPropertyTable MCAndroidInputControl::kPropertyTable =`
`285`	`285`
`286`	`286`	`MCNativeControlActionInfo MCAndroidInputControl::kActions[] =`
`287`	`287`	`{`
	`288`	`+ DEFINE_CTRL_EXEC_METHOD(Focus, Void, MCAndroidInputControl, Focus)`
`288`	`289`	`};`
`289`	`290`
`290`	`291`	`MCNativeControlActionTable MCAndroidInputControl::kActionTable =`
`291`	`292`	`{`
`292`	`293`	`&MCAndroidControl::kActionTable,`
`293`		`- 0,`
`294`		`- nil,`
	`294`	`+ sizeof(kActions) / sizeof(kActions[0]),`
	`295`	`+ &kActions[0],`
`295`	`296`	`};`
`296`	`297`
`297`	`298`	`////////////////////////////////////////////////////////////////////////////////`