libcore: Ensure MCLog() macros can be called with only a string

peter-b · peter-b · commit 15dd78e50a4a · 2016-09-29T15:48:11.000+01:00
GCC doesn't like variadic templates with empty variadic argument
lists.  This meant that using `MCLog("message")` in code that used
libcore's log macros would fail to compile.  However, this can be
worked around by making libcore's `MCLog()` a variadic macro with no
named arguments.  This was already the case in libfoundation.
diff --git a/libcore/include/core.h b/libcore/include/core.h
@@ -168,15 +168,15 @@ extern void __MCAssert(const char *file, uint32_t line, const char *message);
 #define MCAssert(m_expr) (void)( (!!(m_expr)) || (__MCAssert(__FILE__, __LINE__, #m_expr), 0) )
 
 extern void __MCLog(const char *file, uint32_t line, const char *format, ...);
-#define MCLog(m_format, ...) __MCLog(__FILE__, __LINE__, m_format, __VA_ARGS__)
+#define MCLog(...) __MCLog(__FILE__, __LINE__, __VA_ARGS__)
 
 extern void __MCLogWithTrace(const char *file, uint32_t line, const char *format, ...);
-#define MCLogWithTrace(m_format, ...) __MCLogWithTrace(__FILE__, __LINE__, m_format, __VA_ARGS__)
+#define MCLogWithTrace(...) __MCLogWithTrace(__FILE__, __LINE__, __VA_ARGS__)
 
 #else
 #define MCAssert(expr)
-#define MCLog(m_format, ...) 
-#define MCLogWithTrace(m_format, ...)
+#define MCLog(...)
+#define MCLogWithTrace(...)
 #endif
 
 #define MC_CONCAT(X,Y) MC_CONCAT_(X,Y)
