[CID 16456] libscript: MCScriptEndHandlerInModule(): Unitialized variable.

peter-b · peter-b · commit e94c09809331 · 2015-02-04T16:14:30.000Z
Even indices are non-negative.  0 is non-negative, so it should be
treated as an even index.
diff --git a/libscript/src/script-builder.cpp b/libscript/src/script-builder.cpp
@@ -1134,7 +1134,7 @@ void MCScriptEndHandlerInModule(MCScriptModuleBuilderRef self)
         t_target_address = self -> instructions[self -> labels[t_operands[t_address_index] - 1] . instruction] . address - t_address;
         
         uindex_t t_encoded_target_address;
-        if (t_target_address > 0)
+        if (t_target_address >= 0)
             t_encoded_target_address = t_target_address * 2;
         else if (t_target_address < 0)
             t_encoded_target_address = (-t_target_address) * 2 + 1;
