Added DirectionsRefreshResponse#fromJson(Reader) (#1629)

DzmitryFomchyn · web-flow · commit 5eddaf60d05f · 2026-01-16T17:36:41.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 Mapbox welcomes participation and contributions from everyone.
 
 ### main
+- Added `DirectionsRefreshResponse#fromJson(Reader)`, a static factory method that deserializes a `DirectionsRefreshResponse` from a `java.io.Reader`.
 
 ### v7.9.0 - November 20, 2025
 
diff --git a/services-directions-refresh-models/src/main/java/com/mapbox/api/directionsrefresh/v1/models/DirectionsRefreshResponse.java b/services-directions-refresh-models/src/main/java/com/mapbox/api/directionsrefresh/v1/models/DirectionsRefreshResponse.java
@@ -10,6 +10,8 @@
 import com.mapbox.api.directions.v5.DirectionsAdapterFactory;
 import com.mapbox.api.directionsrefresh.v1.DirectionsRefreshAdapterFactory;
 
+import java.io.Reader;
+
 /**
  * Response object for Directions Refresh requests.
  *
@@ -88,10 +90,26 @@ public static TypeAdapter<DirectionsRefreshResponse> typeAdapter(Gson gson) {
    * @since 4.4.0
    */
   public static DirectionsRefreshResponse fromJson(String json) {
-    GsonBuilder gsonBuilder = new GsonBuilder();
-    gsonBuilder.registerTypeAdapterFactory(DirectionsRefreshAdapterFactory.create())
-      .registerTypeAdapterFactory(DirectionsAdapterFactory.create());
-    return gsonBuilder.create().fromJson(json, DirectionsRefreshResponse.class);
+    return createGson().fromJson(json, DirectionsRefreshResponse.class);
+  }
+
+  /**
+   * Deserializes a {@link DirectionsRefreshResponse} from the given reader.
+   *
+   * @param json a {@link Reader} that provides valid JSON representing a
+   *   Directions Refresh response
+   * @return a new {@link DirectionsRefreshResponse} instance created from the provided reader
+   */
+  public static DirectionsRefreshResponse fromJson(@NonNull Reader json) {
+    return createGson().fromJson(json, DirectionsRefreshResponse.class);
+  }
+
+  @NonNull
+  private static Gson createGson() {
+    return new GsonBuilder()
+      .registerTypeAdapterFactory(DirectionsRefreshAdapterFactory.create())
+      .registerTypeAdapterFactory(DirectionsAdapterFactory.create())
+      .create();
   }
 
   /**
diff --git a/services-directions-refresh-models/src/test/java/com.mapbox.api.directionsrefresh.v1.models/DirectionsRefreshResponseTest.java b/services-directions-refresh-models/src/test/java/com.mapbox.api.directionsrefresh.v1.models/DirectionsRefreshResponseTest.java
@@ -9,6 +9,7 @@
 import org.junit.Test;
 
 import java.io.IOException;
+import java.io.InputStreamReader;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
@@ -17,6 +18,7 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
 
 public class DirectionsRefreshResponseTest extends TestUtils {
 
@@ -69,6 +71,24 @@ public void testSerializationDeserialization() throws IOException {
     assertEquals(fromJson1, fromJson2);
   }
 
+  @Test
+  public void testDeserializationFromReader() {
+    final InputStreamReader reader = getResourceInputSteamReader(DIRECTIONS_REFRESH_V1_WAYPOINTS);
+    final DirectionsRefreshResponse response = DirectionsRefreshResponse.fromJson(reader);
+
+    assertEquals("Ok", response.code());
+    assertNotNull(response.route());
+    assertNotNull(response.route().legs());
+
+    final RouteLegRefresh leg = response.route().legs().get(0);
+    assertNotNull(leg);
+    assertNotNull(leg.annotation());
+    assertFalse(leg.annotation().congestion().isEmpty());
+    assertFalse(leg.annotation().trafficTendency().isEmpty());
+    assertFalse(leg.incidents().isEmpty());
+    assertFalse(leg.closures().isEmpty());
+  }
+
   @Test
   public void accessUnrecognizedProperties() throws Exception {
     Map<String, JsonElement> expected = new HashMap<>();
