Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: exercism/cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: pdmoore/cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Aug 4, 2023

  1. Update vehicle_purchase_test.cpp 

    Current tests for choose_vehicle allow a simplistic implementation of 
return option1 + " is clearly the better choice.";
to pass all tests without comparing option1 and option2.

This is due to the current tests all passing in option1 and option2 sorted in lexicographic order already.

This change swaps option1 and option2 for a couple of the tests which forces the implementation to compare the parameters.

This change will not impact existing solutions that are correctly implemented.
    @pdmoore
    pdmoore authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4c98342 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from pdmoore/pdmoore-patch-1 

    Vehicle Purchase - weak tests for 2nd requirement
    @pdmoore
    pdmoore authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2679c47 View commit details
    Browse the repository at this point in the history
Loading