-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathtest_embedding_server.py
More file actions
979 lines (781 loc) · 36 KB
/
test_embedding_server.py
File metadata and controls
979 lines (781 loc) · 36 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
"""Comprehensive tests for the embedding server module.
These tests verify:
1. Server initialization and configuration
2. Health check endpoint
3. Heartbeat and disconnect endpoints
4. Embed and embed_query endpoints
5. Rerank endpoint with model switching
6. Config endpoint
7. Idle checker and config watcher background tasks
8. Cleanup and shutdown logic
9. Error handling
"""
import asyncio
import json
import os
import tempfile
import threading
from pathlib import Path
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
# We'll use httpx for async testing of FastAPI
pytest.importorskip("httpx")
# ============================================================================
# Fixtures
# ============================================================================
@pytest.fixture
def mock_config():
"""Create a mock Config object with default test values."""
config = MagicMock()
config.get_embedding_model.return_value = "test-embedding-model"
config.get_reranker_model.return_value = "test-reranker-model"
config.is_reranker_enabled.return_value = True
config.get_model_idle_timeout.return_value = 1800
config.get_database_path.return_value = tempfile.gettempdir()
config.has_changed.return_value = False
config.reload.return_value = None
return config
@pytest.fixture
def mock_embedding_model():
"""Create a mock embedding model."""
model = MagicMock()
model.model_name = "test-embedding-model"
model.embed_batch.return_value = [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
model.embed_query.return_value = [0.7, 0.8, 0.9]
model.get_embedding_dimension.return_value = 384
model.clear_cache = MagicMock()
model.unload_model = MagicMock()
return model
@pytest.fixture
def mock_reranker():
"""Create a mock reranker."""
reranker = MagicMock()
reranker.model_name = "test-reranker-model"
reranker.rerank.return_value = [
{"text": "doc1", "score": 0.9, "metadata": {}},
{"text": "doc2", "score": 0.8, "metadata": {}},
]
reranker.clear_cache = MagicMock()
reranker.unload_model = MagicMock()
return reranker
@pytest.fixture
def temp_cache_dir():
"""Create a temporary cache directory for server files."""
temp_dir = tempfile.mkdtemp()
yield temp_dir
# Cleanup
import shutil
shutil.rmtree(temp_dir, ignore_errors=True)
@pytest.fixture
def embedding_server(mock_config, temp_cache_dir):
"""Create an EmbeddingServer instance with mocked dependencies."""
# Patch Config at the source where it's imported
with patch("code_rag.config.config.Config", return_value=mock_config):
from code_rag.embedding_server import EmbeddingServer
server = EmbeddingServer.__new__(EmbeddingServer)
# Manually set up attributes (avoiding __init__ which imports Config)
server.port = 8199
server.clients = {}
server.clients_lock = threading.Lock()
server.shutdown_event = asyncio.Event()
server._embedding_model = None
server._reranker = None
server._models_loaded = False
server._models_lock = threading.Lock()
server.config = mock_config
yield server
@pytest.fixture
def server_with_models(embedding_server, mock_embedding_model, mock_reranker):
"""Embedding server with pre-loaded mock models."""
embedding_server._embedding_model = mock_embedding_model
embedding_server._reranker = mock_reranker
embedding_server._models_loaded = True
return embedding_server
# ============================================================================
# Test: Server Initialization
# ============================================================================
class TestServerInitialization:
"""Tests for EmbeddingServer initialization."""
def test_default_port(self, mock_config, temp_cache_dir):
"""Test server initializes with default port."""
import code_rag.embedding_server as server_mod
from code_rag.embedding_server import DEFAULT_PORT
# Create server using __new__ and set attributes directly
server = server_mod.EmbeddingServer.__new__(server_mod.EmbeddingServer)
server.port = DEFAULT_PORT
assert server.port == DEFAULT_PORT
def test_custom_port(self, mock_config, temp_cache_dir):
"""Test server initializes with custom port."""
import code_rag.embedding_server as server_mod
from code_rag.embedding_server import EmbeddingServer
server = server_mod.EmbeddingServer.__new__(server_mod.EmbeddingServer)
server.port = 9999
assert server.port == 9999
def test_initial_state(self, embedding_server):
"""Test server starts with no clients and no models loaded."""
assert len(embedding_server.clients) == 0
assert embedding_server._embedding_model is None
assert embedding_server._reranker is None
assert embedding_server._models_loaded is False
# ============================================================================
# Test: Utility Functions
# ============================================================================
class TestUtilityFunctions:
"""Tests for utility functions."""
def test_find_free_port_success(self):
"""Test find_free_port returns a valid port."""
from code_rag.embedding_server import find_free_port
port = find_free_port(10000)
assert isinstance(port, int)
assert port >= 10000
def test_find_free_port_in_use(self):
"""Test find_free_port skips ports in use."""
import socket
from code_rag.embedding_server import find_free_port
# Bind a port with listen to actually block it
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
sock.bind(("127.0.0.1", 0))
sock.listen(1) # Need to listen to fully occupy the port
bound_port = sock.getsockname()[1]
try:
# While the port is bound and listening, find_free_port should skip it
port = find_free_port(bound_port)
# Port should be different or at least the function completed
assert port >= bound_port
finally:
sock.close()
def test_find_free_port_no_available(self):
"""Test find_free_port raises when no ports available."""
from code_rag.embedding_server import find_free_port
# Mock socket to always fail
with patch("socket.socket") as mock_socket:
mock_socket.return_value.__enter__.return_value.bind.side_effect = OSError
with pytest.raises(RuntimeError, match="Could not find a free port"):
find_free_port(12000, max_attempts=5)
def test_get_lock_file_path(self, temp_cache_dir):
"""Test get_lock_file_path returns correct path."""
mock_config = MagicMock()
mock_config.get_database_path.return_value = temp_cache_dir
with patch("code_rag.config.config.Config", return_value=mock_config):
from code_rag.embedding_server import get_lock_file_path
path = get_lock_file_path()
assert path.name == "embedding_server.lock"
def test_get_server_info_path(self, temp_cache_dir):
"""Test get_server_info_path returns correct path."""
mock_config = MagicMock()
mock_config.get_database_path.return_value = temp_cache_dir
with patch("code_rag.config.config.Config", return_value=mock_config):
from code_rag.embedding_server import get_server_info_path
path = get_server_info_path()
assert path.name == "embedding_server.json"
# ============================================================================
# Test: FastAPI Endpoints (using TestClient)
# ============================================================================
class TestFastAPIEndpoints:
"""Tests for FastAPI endpoints using httpx TestClient."""
@pytest.fixture
def app_client(self, server_with_models):
"""Create a test client for the FastAPI app."""
from typing import Any, Dict, List, Optional
# Create app without lifespan to avoid background tasks
from fastapi import FastAPI
from httpx import ASGITransport, AsyncClient
from pydantic import BaseModel
app = FastAPI(title="Test App")
server = server_with_models
# Re-create endpoints without lifespan
class HeartbeatRequest(BaseModel):
client_id: str
class EmbedRequest(BaseModel):
texts: List[str]
client_id: str
class EmbedQueryRequest(BaseModel):
query: str
client_id: str
class RerankRequest(BaseModel):
query: str
documents: List[str]
metadatas: Optional[List[Dict[str, Any]]] = None
top_k: int = 5
client_id: str
model: Optional[str] = None
class DimensionRequest(BaseModel):
client_id: str
@app.get("/health")
async def health():
return {
"status": "ok",
"clients": len(server.clients),
"embedding_model": server.config.get_embedding_model(),
"reranker_enabled": server.config.is_reranker_enabled(),
"reranker_model": (
server.config.get_reranker_model()
if server.config.is_reranker_enabled()
else None
),
}
@app.post("/heartbeat")
async def heartbeat(request: HeartbeatRequest):
import time
with server.clients_lock:
server.clients[request.client_id] = time.time()
return {"status": "ok"}
@app.post("/disconnect")
async def disconnect(request: HeartbeatRequest):
with server.clients_lock:
server.clients.pop(request.client_id, None)
return {"status": "ok"}
@app.post("/embed")
async def embed(request: EmbedRequest):
server._update_heartbeat(request.client_id)
embeddings = server._embedding_model.embed_batch(request.texts)
return {"embeddings": embeddings}
@app.post("/embed_query")
async def embed_query(request: EmbedQueryRequest):
server._update_heartbeat(request.client_id)
embedding = server._embedding_model.embed_query(request.query)
return {"embedding": embedding}
@app.post("/embedding_dimension")
async def embedding_dimension(request: DimensionRequest):
server._update_heartbeat(request.client_id)
dim = server._embedding_model.get_embedding_dimension()
return {"dimension": dim}
@app.post("/clear_cache")
async def clear_cache(request: DimensionRequest):
server._update_heartbeat(request.client_id)
if server._embedding_model and hasattr(
server._embedding_model, "clear_cache"
):
server._embedding_model.clear_cache()
if server._reranker and hasattr(server._reranker, "clear_cache"):
server._reranker.clear_cache()
return {"status": "ok"}
@app.post("/rerank")
async def rerank(request: RerankRequest):
server._update_heartbeat(request.client_id)
if not server.config.is_reranker_enabled() and not request.model:
return {"error": "Reranker not enabled", "results": []}
results = server._reranker.rerank(
request.query,
request.documents,
metadatas=request.metadatas,
top_k=request.top_k,
)
return {"results": results}
@app.get("/config")
async def get_config():
return {
"embedding_model": server.config.get_embedding_model(),
"reranker_enabled": server.config.is_reranker_enabled(),
"reranker_model": (
server.config.get_reranker_model()
if server.config.is_reranker_enabled()
else None
),
}
return AsyncClient(transport=ASGITransport(app=app), base_url="http://test")
@pytest.mark.asyncio
async def test_health_endpoint(self, app_client):
"""Test /health endpoint returns correct status."""
async with app_client as client:
response = await client.get("/health")
assert response.status_code == 200
data = response.json()
assert data["status"] == "ok"
assert "clients" in data
assert data["embedding_model"] == "test-embedding-model"
assert data["reranker_enabled"] is True
assert data["reranker_model"] == "test-reranker-model"
@pytest.mark.asyncio
async def test_heartbeat_endpoint(self, app_client, server_with_models):
"""Test /heartbeat endpoint registers client."""
async with app_client as client:
response = await client.post(
"/heartbeat", json={"client_id": "test-client-123"}
)
assert response.status_code == 200
assert response.json()["status"] == "ok"
assert "test-client-123" in server_with_models.clients
@pytest.mark.asyncio
async def test_disconnect_endpoint(self, app_client, server_with_models):
"""Test /disconnect endpoint removes client."""
# First register a client
server_with_models.clients["test-client-456"] = 1234567890.0
async with app_client as client:
response = await client.post(
"/disconnect", json={"client_id": "test-client-456"}
)
assert response.status_code == 200
assert response.json()["status"] == "ok"
assert "test-client-456" not in server_with_models.clients
@pytest.mark.asyncio
async def test_embed_endpoint(self, app_client, mock_embedding_model):
"""Test /embed endpoint returns embeddings."""
async with app_client as client:
response = await client.post(
"/embed", json={"texts": ["hello", "world"], "client_id": "test-client"}
)
assert response.status_code == 200
data = response.json()
assert "embeddings" in data
mock_embedding_model.embed_batch.assert_called_once_with(["hello", "world"])
@pytest.mark.asyncio
async def test_embed_query_endpoint(self, app_client, mock_embedding_model):
"""Test /embed_query endpoint returns query embedding."""
async with app_client as client:
response = await client.post(
"/embed_query",
json={"query": "search query", "client_id": "test-client"},
)
assert response.status_code == 200
data = response.json()
assert "embedding" in data
mock_embedding_model.embed_query.assert_called_once_with("search query")
@pytest.mark.asyncio
async def test_embedding_dimension_endpoint(self, app_client, mock_embedding_model):
"""Test /embedding_dimension endpoint returns dimension."""
async with app_client as client:
response = await client.post(
"/embedding_dimension", json={"client_id": "test-client"}
)
assert response.status_code == 200
data = response.json()
assert data["dimension"] == 384
@pytest.mark.asyncio
async def test_clear_cache_endpoint(
self, app_client, mock_embedding_model, mock_reranker
):
"""Test /clear_cache endpoint clears model caches."""
async with app_client as client:
response = await client.post(
"/clear_cache", json={"client_id": "test-client"}
)
assert response.status_code == 200
assert response.json()["status"] == "ok"
mock_embedding_model.clear_cache.assert_called_once()
mock_reranker.clear_cache.assert_called_once()
@pytest.mark.asyncio
async def test_rerank_endpoint(self, app_client, mock_reranker):
"""Test /rerank endpoint returns reranked results."""
async with app_client as client:
response = await client.post(
"/rerank",
json={
"query": "test query",
"documents": ["doc1", "doc2"],
"top_k": 2,
"client_id": "test-client",
},
)
assert response.status_code == 200
data = response.json()
assert "results" in data
assert len(data["results"]) == 2
mock_reranker.rerank.assert_called_once()
@pytest.mark.asyncio
async def test_rerank_endpoint_disabled(self, app_client, server_with_models):
"""Test /rerank returns error when reranker disabled."""
server_with_models.config.is_reranker_enabled.return_value = False
async with app_client as client:
response = await client.post(
"/rerank",
json={
"query": "test query",
"documents": ["doc1", "doc2"],
"top_k": 2,
"client_id": "test-client",
},
)
assert response.status_code == 200
data = response.json()
assert data["error"] == "Reranker not enabled"
assert data["results"] == []
@pytest.mark.asyncio
async def test_config_endpoint(self, app_client):
"""Test /config endpoint returns configuration."""
async with app_client as client:
response = await client.get("/config")
assert response.status_code == 200
data = response.json()
assert data["embedding_model"] == "test-embedding-model"
assert data["reranker_enabled"] is True
assert data["reranker_model"] == "test-reranker-model"
# ============================================================================
# Test: Model Loading
# ============================================================================
class TestModelLoading:
"""Tests for model loading logic."""
def test_load_models_sentence_transformer(self, embedding_server):
"""Test loading SentenceTransformer embedding model."""
embedding_server.config.get_embedding_model.return_value = "all-MiniLM-L6-v2"
embedding_server.config.is_reranker_enabled.return_value = False
mock_st_model = MagicMock()
# Patch at the source module where it's imported from
with patch(
"code_rag.embeddings.sentence_transformer_embedding.SentenceTransformerEmbedding",
return_value=mock_st_model,
) as mock_cls:
embedding_server._load_models()
mock_cls.assert_called_once()
assert embedding_server._models_loaded is True
def test_load_models_openai(self, embedding_server):
"""Test loading OpenAI embedding model."""
embedding_server.config.get_embedding_model.return_value = (
"text-embedding-3-small"
)
embedding_server.config.is_reranker_enabled.return_value = False
mock_litellm_model = MagicMock()
with patch(
"code_rag.embeddings.litellm_embedding.LiteLLMEmbedding",
return_value=mock_litellm_model,
) as mock_cls:
embedding_server._load_models()
mock_cls.assert_called_once_with("text-embedding-3-small")
assert embedding_server._models_loaded is True
def test_load_models_cloud_provider(self, embedding_server):
"""Test loading cloud provider embedding models."""
cloud_models = [
"openai/text-embedding-ada-002",
"azure/text-embedding-3-small",
"vertex_ai/text-embedding-004",
"cohere/embed-english-v3.0",
]
for model_name in cloud_models:
embedding_server._models_loaded = False
embedding_server._embedding_model = None
embedding_server.config.get_embedding_model.return_value = model_name
embedding_server.config.is_reranker_enabled.return_value = False
mock_litellm_model = MagicMock()
with patch(
"code_rag.embeddings.litellm_embedding.LiteLLMEmbedding",
return_value=mock_litellm_model,
):
embedding_server._load_models()
assert embedding_server._models_loaded is True
def test_load_models_with_reranker_enabled(self, embedding_server):
"""Test loading reranker when enabled."""
embedding_server.config.get_embedding_model.return_value = "all-MiniLM-L6-v2"
embedding_server.config.is_reranker_enabled.return_value = True
mock_st_model = MagicMock()
mock_reranker = MagicMock()
with (
patch(
"code_rag.embeddings.sentence_transformer_embedding.SentenceTransformerEmbedding",
return_value=mock_st_model,
),
patch(
"code_rag.reranker.cross_encoder_reranker.CrossEncoderReranker",
return_value=mock_reranker,
) as mock_reranker_cls,
):
embedding_server._load_models()
mock_reranker_cls.assert_called_once()
assert embedding_server._reranker is not None
def test_load_models_with_reranker_disabled(self, embedding_server):
"""Test reranker not loaded when disabled."""
embedding_server.config.get_embedding_model.return_value = "all-MiniLM-L6-v2"
embedding_server.config.is_reranker_enabled.return_value = False
mock_st_model = MagicMock()
with (
patch(
"code_rag.embeddings.sentence_transformer_embedding.SentenceTransformerEmbedding",
return_value=mock_st_model,
),
patch(
"code_rag.reranker.cross_encoder_reranker.CrossEncoderReranker"
) as mock_reranker_cls,
):
embedding_server._load_models()
mock_reranker_cls.assert_not_called()
assert embedding_server._reranker is None
def test_load_models_idempotent(self, embedding_server):
"""Test that _load_models is idempotent."""
embedding_server.config.get_embedding_model.return_value = "all-MiniLM-L6-v2"
embedding_server.config.is_reranker_enabled.return_value = False
mock_st_model = MagicMock()
with patch(
"code_rag.embeddings.sentence_transformer_embedding.SentenceTransformerEmbedding",
return_value=mock_st_model,
) as mock_cls:
embedding_server._load_models()
embedding_server._load_models()
embedding_server._load_models()
# Should only be called once
assert mock_cls.call_count == 1
# ============================================================================
# Test: Config Reload Handling
# ============================================================================
class TestConfigReload:
"""Tests for configuration reload handling."""
def test_handle_config_reload_embedding_model_changed(self, server_with_models):
"""Test handling when embedding model changes."""
server_with_models._embedding_model.model_name = "old-model"
server_with_models.config.get_embedding_model.return_value = "new-model"
server_with_models._handle_config_reload()
assert server_with_models._embedding_model is None
assert server_with_models._models_loaded is False
def test_handle_config_reload_reranker_disabled(
self, server_with_models, mock_reranker
):
"""Test handling when reranker is disabled."""
server_with_models.config.is_reranker_enabled.return_value = False
# Ensure the reranker has the model_name attribute to match embedding model check
server_with_models._embedding_model.model_name = "test-embedding-model"
server_with_models.config.get_embedding_model.return_value = (
"test-embedding-model"
)
server_with_models._handle_config_reload()
mock_reranker.unload_model.assert_called_once()
assert server_with_models._reranker is None
def test_handle_config_reload_reranker_model_changed(
self, server_with_models, mock_reranker
):
"""Test handling when reranker model changes."""
server_with_models._reranker.model_name = "old-reranker"
server_with_models.config.get_reranker_model.return_value = "new-reranker"
# Keep embedding model the same
server_with_models._embedding_model.model_name = "test-embedding-model"
server_with_models.config.get_embedding_model.return_value = (
"test-embedding-model"
)
server_with_models._handle_config_reload()
mock_reranker.unload_model.assert_called_once()
assert server_with_models._reranker is None
assert server_with_models._models_loaded is False
# ============================================================================
# Test: Heartbeat Management
# ============================================================================
class TestHeartbeatManagement:
"""Tests for client heartbeat management."""
def test_update_heartbeat(self, embedding_server):
"""Test _update_heartbeat updates client timestamp."""
import time
before = time.time()
embedding_server._update_heartbeat("client-1")
after = time.time()
assert "client-1" in embedding_server.clients
assert before <= embedding_server.clients["client-1"] <= after
def test_update_heartbeat_multiple_clients(self, embedding_server):
"""Test handling multiple clients."""
embedding_server._update_heartbeat("client-1")
embedding_server._update_heartbeat("client-2")
embedding_server._update_heartbeat("client-3")
assert len(embedding_server.clients) == 3
# ============================================================================
# Test: Cleanup
# ============================================================================
class TestCleanup:
"""Tests for server cleanup."""
def test_cleanup_removes_files(self, embedding_server, temp_cache_dir):
"""Test _cleanup removes lock and info files."""
lock_path = Path(temp_cache_dir) / "embedding_server.lock"
info_path = Path(temp_cache_dir) / "embedding_server.json"
# Create the files
lock_path.write_text("12345")
info_path.write_text('{"port": 8199, "pid": 12345}')
with (
patch(
"code_rag.embedding_server.get_lock_file_path", return_value=lock_path
),
patch(
"code_rag.embedding_server.get_server_info_path", return_value=info_path
),
):
embedding_server._cleanup()
assert not lock_path.exists()
assert not info_path.exists()
def test_cleanup_handles_missing_files(self, embedding_server, temp_cache_dir):
"""Test _cleanup handles missing files gracefully."""
lock_path = Path(temp_cache_dir) / "nonexistent_lock"
info_path = Path(temp_cache_dir) / "nonexistent_info"
with (
patch(
"code_rag.embedding_server.get_lock_file_path", return_value=lock_path
),
patch(
"code_rag.embedding_server.get_server_info_path", return_value=info_path
),
):
# Should not raise
embedding_server._cleanup()
# ============================================================================
# Test: Idle Checker (Async)
# ============================================================================
class TestIdleChecker:
"""Tests for the idle checker background task."""
@pytest.mark.asyncio
async def test_idle_checker_removes_stale_clients(self, embedding_server):
"""Test idle checker removes stale clients."""
import time
from code_rag.embedding_server import HEARTBEAT_TIMEOUT
# Add a stale client
stale_time = time.time() - HEARTBEAT_TIMEOUT - 10
embedding_server.clients["stale-client"] = stale_time
embedding_server.clients["active-client"] = time.time()
# Create a modified idle checker that runs once
async def check_once():
now = time.time()
with embedding_server.clients_lock:
stale_clients = [
cid
for cid, last_seen in embedding_server.clients.items()
if now - last_seen > HEARTBEAT_TIMEOUT
]
for cid in stale_clients:
del embedding_server.clients[cid]
await check_once()
assert "stale-client" not in embedding_server.clients
assert "active-client" in embedding_server.clients
# ============================================================================
# Test: Config Watcher (Async)
# ============================================================================
class TestConfigWatcher:
"""Tests for the config watcher background task."""
@pytest.mark.asyncio
async def test_config_watcher_detects_changes(self, embedding_server, mock_config):
"""Test config watcher detects and handles changes."""
mock_config.has_changed.return_value = True
# Simulate one check cycle
if mock_config.has_changed():
mock_config.reload()
embedding_server._handle_config_reload()
mock_config.reload.assert_called_once()
@pytest.mark.asyncio
async def test_config_watcher_no_changes(self, embedding_server, mock_config):
"""Test config watcher does nothing when no changes."""
mock_config.has_changed.return_value = False
# Simulate one check cycle
if mock_config.has_changed():
mock_config.reload()
mock_config.reload.assert_not_called()
# ============================================================================
# Test: Server Run (Integration-like)
# ============================================================================
class TestServerRun:
"""Tests for server run logic."""
def test_run_checks_existing_server(self, embedding_server, temp_cache_dir):
"""Test run checks for existing server."""
lock_path = Path(temp_cache_dir) / "embedding_server.lock"
# Write a lock file with current process PID (which exists)
lock_path.write_text(str(os.getpid()))
with (
patch(
"code_rag.embedding_server.get_lock_file_path", return_value=lock_path
),
patch("code_rag.embedding_server.get_server_info_path"),
patch("sys.exit") as mock_exit,
):
# Mock exit to raise SystemExit to stop further execution
mock_exit.side_effect = SystemExit(1)
try:
embedding_server.run()
except SystemExit:
pass
# Check that exit was called with 1 (existing server detected)
mock_exit.assert_called_with(1)
def test_run_cleans_stale_lock(self, embedding_server, temp_cache_dir):
"""Test run cleans stale lock file from dead process."""
lock_path = Path(temp_cache_dir) / "embedding_server.lock"
info_path = Path(temp_cache_dir) / "embedding_server.json"
# Write a lock file with invalid PID
lock_path.write_text("999999999") # Likely non-existent PID
with (
patch(
"code_rag.embedding_server.get_lock_file_path", return_value=lock_path
),
patch(
"code_rag.embedding_server.get_server_info_path", return_value=info_path
),
patch("code_rag.embedding_server.find_free_port", return_value=8199),
patch("code_rag.embedding_server.uvicorn") as mock_uvicorn,
patch.object(embedding_server, "create_app", return_value=MagicMock()),
):
# Mock uvicorn.run to prevent actual server start
mock_uvicorn.run = MagicMock()
embedding_server.run()
# Lock should be cleaned up (or overwritten)
# The important thing is no crash and uvicorn.run was called
mock_uvicorn.run.assert_called_once()
def test_run_writes_server_info(self, embedding_server, temp_cache_dir):
"""Test run writes server info file."""
lock_path = Path(temp_cache_dir) / "embedding_server.lock"
info_path = Path(temp_cache_dir) / "embedding_server.json"
with (
patch(
"code_rag.embedding_server.get_lock_file_path", return_value=lock_path
),
patch(
"code_rag.embedding_server.get_server_info_path", return_value=info_path
),
patch("code_rag.embedding_server.find_free_port", return_value=8199),
patch("code_rag.embedding_server.uvicorn") as mock_uvicorn,
patch.object(embedding_server, "create_app", return_value=MagicMock()),
patch.object(embedding_server, "_cleanup"),
):
# Mock uvicorn.run to not actually start server
mock_uvicorn.run = MagicMock()
embedding_server.run()
# Verify info file was written
assert info_path.exists()
info_data = json.loads(info_path.read_text())
assert info_data["port"] == 8199
assert "pid" in info_data
# ============================================================================
# Test: Main Entry Point
# ============================================================================
class TestMainEntryPoint:
"""Tests for the main() entry point."""
def test_main_default_port(self):
"""Test main uses default port."""
from code_rag.embedding_server import DEFAULT_PORT
with (
patch("code_rag.embedding_server.EmbeddingServer") as mock_server_cls,
patch("sys.argv", ["embedding_server"]),
):
mock_server = MagicMock()
mock_server_cls.return_value = mock_server
from code_rag.embedding_server import main
main()
mock_server_cls.assert_called_once_with(port=DEFAULT_PORT)
mock_server.run.assert_called_once()
def test_main_custom_port(self):
"""Test main accepts custom port argument."""
with (
patch("code_rag.embedding_server.EmbeddingServer") as mock_server_cls,
patch("sys.argv", ["embedding_server", "--port", "9999"]),
):
mock_server = MagicMock()
mock_server_cls.return_value = mock_server
from code_rag.embedding_server import main
main()
mock_server_cls.assert_called_once_with(port=9999)
# ============================================================================
# Test: Lazy Imports
# ============================================================================
class TestLazyImports:
"""Tests for lazy import mechanism."""
def test_ensure_imports_loads_dependencies(self):
"""Test _ensure_imports loads FastAPI and uvicorn."""
# Reset globals to test fresh import
import code_rag.embedding_server as server_module
# Save original values
original_uvicorn = server_module.uvicorn
original_fastapi = server_module.FastAPI
original_basemodel = server_module.BaseModel
try:
# Reset to None
server_module.uvicorn = None
server_module.FastAPI = None
server_module.BaseModel = None
# Call _ensure_imports
server_module._ensure_imports()
# Verify imports happened
assert server_module.uvicorn is not None
assert server_module.FastAPI is not None
assert server_module.BaseModel is not None
finally:
# Restore
server_module.uvicorn = original_uvicorn
server_module.FastAPI = original_fastapi
server_module.BaseModel = original_basemodel