Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kasun/python-tail
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rgalonso/python-tail
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 5, 2018

  1. optional support for binary files 

    Added an optional argument to constructor to specify the mode argument to the file open command.  Defaults to 'r', for backwards-compatibility.
The specific use case this addresses is supporting binary-encoded encoded files by specifying the mode as 'rb'.  While using this module to parse pcap files generated by Wireshark, I found this to be a necessary change.
    @rgalonso
    rgalonso authored Apr 5, 2018
    Configuration menu
    Copy the full SHA
    e4057d8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from rgalonso/rgalonso_binary_support 

    optional support for binary files
    @rgalonso
    rgalonso authored Apr 5, 2018
    Configuration menu
    Copy the full SHA
    ce506a4 View commit details
    Browse the repository at this point in the history

  3. start at end of file (original behavior) 

    Last commit accidentally checked in a debug change where I started the initial seek at the beginning of the file instead of the end.  Restoring this to the end so that the only delta is just the binary support intended.
    @rgalonso
    rgalonso authored Apr 5, 2018
    Configuration menu
    Copy the full SHA
    4c25450 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from rgalonso/rgalonso_binary_support 

    start at end of file (original behavior)
    @rgalonso
    rgalonso authored Apr 5, 2018
    Configuration menu
    Copy the full SHA
    2e05bd4 View commit details
    Browse the repository at this point in the history
Loading