Merge pull request code-corps#277 from code-corps/add-project-categories-show

joshsmith · web-flow · commit 63abb83fed74 · 2016-09-27T16:04:17.000-07:00
Add show and index actions to ProjectCategory
diff --git a/test/controllers/project_category_controller_test.exs b/test/controllers/project_category_controller_test.exs
@@ -21,6 +21,67 @@ defmodule CodeCorps.ProjectCategoryControllerTest do
     }
   end
 
+  describe "index" do
+    test "lists all entries on index", %{conn: conn} do
+      conn = get conn, project_category_path(conn, :index)
+      assert json_response(conn, 200)["data"] == []
+    end
+
+    test "filters resources on index", %{conn: conn} do
+      arts = insert(:category, name: "Arts")
+      society = insert(:category, name: "Society")
+      technology = insert(:category, name: "Technology")
+
+      project = insert(:project)
+      project_category_1 = insert(:project_category, project: project, category: arts)
+      project_category_2 = insert(:project_category, project: project, category: society)
+      insert(:project_category, project: project, category: technology)
+
+      json =
+        conn
+        |> get("project-categories/?filter[id]=#{project_category_1.id},#{project_category_2.id}")
+        |> json_response(200)
+      data = json["data"]
+      assert length(data) == 2
+      [first_result, second_result | _] = data
+
+      assert first_result["id"] == "#{project_category_1.id}"
+      assert first_result["relationships"]["project"]["data"]["id"] == "#{project.id}"
+      assert first_result["relationships"]["project"]["data"]["type"] == "project"
+      assert first_result["relationships"]["category"]["data"]["id"] == "#{arts.id}"
+      assert first_result["relationships"]["category"]["data"]["type"] == "category"
+
+      assert second_result["id"] == "#{project_category_2.id}"
+      assert second_result["relationships"]["project"]["data"]["id"] == "#{project.id}"
+      assert second_result["relationships"]["project"]["data"]["type"] == "project"
+      assert second_result["relationships"]["category"]["data"]["id"] == "#{society.id}"
+      assert second_result["relationships"]["category"]["data"]["type"] == "category"
+    end
+  end
+
+  describe "show" do
+    test "shows chosen resource", %{conn: conn} do
+      category = insert(:category)
+      project = insert(:project)
+      project_category = insert(:project_category, project: project, category: category)
+      conn = get conn, project_category_path(conn, :show, project_category)
+      data = json_response(conn, 200)["data"]
+      assert data["id"] == "#{project_category.id}"
+      assert data["type"] == "project-category"
+      assert data["attributes"] == %{}
+      assert data["relationships"]["project"]["data"]["id"] == "#{project.id}"
+      assert data["relationships"]["project"]["data"]["type"] == "project"
+      assert data["relationships"]["category"]["data"]["id"] == "#{category.id}"
+      assert data["relationships"]["category"]["data"]["type"] == "category"
+    end
+
+    test "does not show resource and instead throw error when id is nonexistent", %{conn: conn} do
+      assert_error_sent 404, fn ->
+        get conn, project_category_path(conn, :show, -1)
+      end
+    end
+  end
+
   describe "create" do
     @tag authenticated: :admin
     test "creates and renders resource when data is valid", %{conn: conn} do
diff --git a/web/controllers/project_category_controller.ex b/web/controllers/project_category_controller.ex
@@ -1,12 +1,31 @@
 defmodule CodeCorps.ProjectCategoryController do
   use CodeCorps.Web, :controller
 
+  import CodeCorps.ControllerHelpers
+
   alias JaSerializer.Params
   alias CodeCorps.ProjectCategory
 
   plug :load_and_authorize_resource, model: ProjectCategory, only: [:create, :delete]
   plug :scrub_params, "data" when action in [:create]
 
+  def index(conn, params) do
+    project_categories =
+      case params do
+        %{"filter" => %{"id" => id_list}} ->
+          ids = id_list |> coalesce_id_string
+          ProjectCategory
+          |> preload([:project, :category])
+          |> where([p], p.id in ^ids)
+          |> Repo.all
+        %{} ->
+          ProjectCategory
+          |> preload([:user, :category])
+          |> Repo.all
+      end
+    render(conn, "index.json-api", data: project_categories)
+  end
+
   def create(conn, %{"data" => data = %{"type" => "project-category"}}) do
     changeset = %ProjectCategory{} |> ProjectCategory.create_changeset(Params.to_attributes(data))
 
@@ -24,6 +43,14 @@ defmodule CodeCorps.ProjectCategoryController do
     end
   end
 
+  def show(conn, %{"id" => id}) do
+    project_category =
+      ProjectCategory
+      |> preload([:project, :category])
+      |> Repo.get!(id)
+    render(conn, "show.json-api", data: project_category)
+  end
+
   def delete(conn, %{"id" => id}) do
     ProjectCategory |> Repo.get!(id) |> Repo.delete!
 
diff --git a/web/router.ex b/web/router.ex
@@ -61,6 +61,7 @@ defmodule CodeCorps.Router do
       resources "/posts", PostController, only: [:index, :show]
     end
 
+    resources "/project-categories", ProjectCategoryController, only: [:index, :show]
     resources "/project-skills", ProjectSkillController, only: [:index, :show]
     resources "/roles", RoleController, only: [:index, :show]
     resources "/skills", SkillController, only: [:index, :show]
