Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: logdna/python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sebdiem/python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 23, 2024

  1. rename functions for consistency 

    We find the same pattern with buffer_log and flush: a sync version and a
version distributed to a thread pool.
This commit harmonizes namings:
- schedule_flush_sync => flush_with_lock
- try_lock_and_do_flush_request => flush_sync
    @sebdiem
    sebdiem committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0cb6107 View commit details
    Browse the repository at this point in the history

  2. add one test proving deadlock 

    when logging and closing simultaneously the code enters a deadlock.
    @sebdiem
    sebdiem committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cb81745 View commit details
    Browse the repository at this point in the history

  3. remove risk of deadlock in close function 

    The previous version was prone to a deadlock (see added test in previous
commit)
    @sebdiem
    sebdiem committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    26442d7 View commit details
    Browse the repository at this point in the history
Loading