Fix quality flaws (SonarSource#651)

guillaume-dequenne · web-flow · commit ed10bc3d5df0 · 2020-03-20T13:12:41.000+01:00
diff --git a/python-checks/src/main/java/org/sonar/python/checks/ConfusingWalrusCheck.java b/python-checks/src/main/java/org/sonar/python/checks/ConfusingWalrusCheck.java
@@ -29,7 +29,6 @@
 import org.sonar.plugins.python.api.tree.Argument;
 import org.sonar.plugins.python.api.tree.AssignmentExpression;
 import org.sonar.plugins.python.api.tree.BaseTreeVisitor;
-import org.sonar.plugins.python.api.tree.Expression;
 import org.sonar.plugins.python.api.tree.FormattedExpression;
 import org.sonar.plugins.python.api.tree.Parameter;
 import org.sonar.plugins.python.api.tree.RegularArgument;
@@ -45,7 +44,7 @@ public class ConfusingWalrusCheck extends PythonSubscriptionCheck {
 
   @Override
   public void initialize(Context context) {
-    context.registerSyntaxNodeConsumer(Tree.Kind.ASSIGNMENT_EXPRESSION, this::checkAssignmentExpression);
+    context.registerSyntaxNodeConsumer(Tree.Kind.ASSIGNMENT_EXPRESSION, ConfusingWalrusCheck::checkAssignmentExpression);
 
     context.registerSyntaxNodeConsumer(Tree.Kind.STRING_ELEMENT, ctx -> {
       StringElement stringElement = (StringElement) ctx.syntaxNode();
@@ -76,7 +75,7 @@ private static void checkNestedWalrus(SubscriptionContext ctx, Tree tree, String
     }
   }
 
-  private void checkAssignmentExpression(SubscriptionContext ctx) {
+  private static void checkAssignmentExpression(SubscriptionContext ctx) {
     AssignmentExpression assignmentExpression = (AssignmentExpression) ctx.syntaxNode();
     Optional<Tree> parentTree = Optional.ofNullable(TreeUtils.firstAncestor(assignmentExpression, a -> !a.is(Tree.Kind.PARENTHESIZED)));
     parentTree.ifPresent(parent -> {
diff --git a/python-checks/src/main/java/org/sonar/python/checks/DuplicatedMethodFieldNamesCheck.java b/python-checks/src/main/java/org/sonar/python/checks/DuplicatedMethodFieldNamesCheck.java
@@ -21,11 +21,9 @@
 
 import java.util.ArrayList;
 import java.util.Comparator;
-import java.util.HashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Optional;
-import java.util.Set;
 import java.util.stream.Collectors;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
@@ -36,7 +34,6 @@
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.symbols.Symbol;
 import org.sonar.plugins.python.api.tree.BaseTreeVisitor;
-import org.sonar.plugins.python.api.symbols.Usage;
 import org.sonar.python.tree.TreeUtils;
 
 @Rule(key = "S1845")
diff --git a/python-checks/src/main/java/org/sonar/python/checks/SelfAssignmentCheck.java b/python-checks/src/main/java/org/sonar/python/checks/SelfAssignmentCheck.java
@@ -62,10 +62,10 @@ public void initialize(Context context) {
 
     context.registerSyntaxNodeConsumer(Tree.Kind.ANNOTATED_ASSIGNMENT, this::checkAnnotatedAssignment);
 
-    context.registerSyntaxNodeConsumer(Tree.Kind.ASSIGNMENT_EXPRESSION, this::checkAssignmentExpression);
+    context.registerSyntaxNodeConsumer(Tree.Kind.ASSIGNMENT_EXPRESSION, SelfAssignmentCheck::checkAssignmentExpression);
   }
 
-  private void checkAssignmentExpression(SubscriptionContext ctx) {
+  private static void checkAssignmentExpression(SubscriptionContext ctx) {
     AssignmentExpression assignmentExpression = (AssignmentExpression) ctx.syntaxNode();
     if (CheckUtils.areEquivalent(assignmentExpression.lhsName(), assignmentExpression.expression())) {
       ctx.addIssue(assignmentExpression.operator(), MESSAGE);
