Skip to content

Commit 0d33662

Browse files
committed
SONARPY-88 Upgrade sslr-squid-bridge to 2.6v
1 parent 4fb81fe commit 0d33662

5 files changed

Lines changed: 7 additions & 17 deletions

File tree

pom.xml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
<dependency>
115115
<groupId>org.codehaus.sonar.sslr-squid-bridge</groupId>
116116
<artifactId>sslr-squid-bridge</artifactId>
117-
<version>2.5.3</version>
117+
<version>2.6</version>
118118
</dependency>
119119
<dependency>
120120
<groupId>junit</groupId>
@@ -136,11 +136,6 @@
136136
<artifactId>logback-classic</artifactId>
137137
<version>0.9.15</version>
138138
</dependency>
139-
<dependency>
140-
<groupId>org.codehaus.sonar.common-rules</groupId>
141-
<artifactId>sonar-common-rules</artifactId>
142-
<version>1.2</version>
143-
</dependency>
144139
<dependency>
145140
<groupId>org.slf4j</groupId>
146141
<artifactId>slf4j-api</artifactId>

sonar-python-plugin/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@
5050
<version>${project.version}</version>
5151
</dependency>
5252

53-
<dependency>
54-
<groupId>org.codehaus.sonar.common-rules</groupId>
55-
<artifactId>sonar-common-rules</artifactId>
56-
</dependency>
57-
5853
<dependency>
5954
<groupId>org.codehaus.sonar.sslr</groupId>
6055
<artifactId>sslr-testing-harness</artifactId>

sonar-python-plugin/src/main/java/org/sonar/plugins/python/PythonCommonRulesEngine.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
*/
2020
package org.sonar.plugins.python;
2121

22-
import org.sonar.commonrules.api.CommonRulesEngine;
23-
import org.sonar.commonrules.api.CommonRulesRepository;
22+
import org.sonar.squidbridge.commonrules.api.CommonRulesEngine;
23+
import org.sonar.squidbridge.commonrules.api.CommonRulesRepository;
2424

2525
public class PythonCommonRulesEngine extends CommonRulesEngine {
2626

sonar-python-plugin/src/test/java/org/sonar/plugins/python/PythonCommonRulesEngineTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
package org.sonar.plugins.python;
2121

2222
import org.junit.Test;
23-
import org.sonar.commonrules.api.CommonRulesRepository;
23+
import org.sonar.squidbridge.commonrules.api.CommonRulesRepository;
2424

2525
import static org.fest.assertions.Assertions.assertThat;
2626

@@ -36,8 +36,8 @@ public void shouldProvideExpectedExtensions() {
3636
public void enable_common_rules() {
3737
PythonCommonRulesEngine engine = new PythonCommonRulesEngine();
3838
CommonRulesRepository repo = engine.newRepository();
39-
assertThat(repo.rules()).hasSize(4);
40-
assertThat(repo.rule(CommonRulesRepository.RULE_INSUFFICIENT_COMMENT_DENSITY)).isNotNull();
39+
assertThat(repo.enabledRuleKeys()).hasSize(4);
40+
assertThat(repo.enableInsufficientCommentDensityRule(null)).isNotNull();
4141
}
4242

4343
}

sslr-python-toolkit/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
<configuration>
106106
<rules>
107107
<requireFilesSize>
108-
<maxsize>3100000</maxsize>
108+
<maxsize>3200000</maxsize>
109109
<minsize>1400000</minsize>
110110
<files>
111111
<file>${project.build.directory}/${project.build.finalName}.jar</file>

0 commit comments

Comments
 (0)