SONARPY-192 Load default profile fron JSON file

pynicolas · pynicolas · commit 6a61dd75a623 · 2017-05-08T11:01:56.000+02:00
diff --git a/sonar-python-plugin/src/main/java/org/sonar/plugins/python/PythonProfile.java b/sonar-python-plugin/src/main/java/org/sonar/plugins/python/PythonProfile.java
@@ -19,12 +19,18 @@
  */
 package org.sonar.plugins.python;
 
+import com.google.common.io.Resources;
+import com.google.gson.Gson;
+import java.io.IOException;
+import java.net.URL;
+import java.nio.charset.StandardCharsets;
+import java.util.Set;
 import org.sonar.api.profiles.ProfileDefinition;
 import org.sonar.api.profiles.RulesProfile;
+import org.sonar.api.rules.Rule;
 import org.sonar.api.rules.RuleFinder;
 import org.sonar.api.utils.ValidationMessages;
 import org.sonar.python.checks.CheckList;
-import org.sonar.squidbridge.annotations.AnnotationBasedProfileBuilder;
 
 public class PythonProfile extends ProfileDefinition {
 
@@ -35,13 +41,31 @@ public PythonProfile(RuleFinder ruleFinder) {
   }
 
   @Override
-  public RulesProfile createProfile(ValidationMessages validation) {
-    AnnotationBasedProfileBuilder annotationBasedProfileBuilder = new AnnotationBasedProfileBuilder(ruleFinder);
-    return annotationBasedProfileBuilder.build(
-        CheckList.REPOSITORY_KEY,
-        CheckList.SONAR_WAY_PROFILE,
-        Python.KEY,
-        CheckList.getChecks(),
-        validation);
+  public RulesProfile createProfile(ValidationMessages messages) {
+    RulesProfile profile = RulesProfile.create(CheckList.SONAR_WAY_PROFILE, Python.KEY);
+
+    loadActiveKeysFromJsonProfile(profile);
+    return profile;
+  }
+
+  private void loadActiveKeysFromJsonProfile(RulesProfile rulesProfile) {
+    for (String ruleKey : activatedRuleKeys()) {
+      Rule rule = ruleFinder.findByKey(CheckList.REPOSITORY_KEY, ruleKey);
+      rulesProfile.activateRule(rule, null);
+    }
+  }
+
+  private static Set<String> activatedRuleKeys() {
+    URL profileUrl = PythonProfile.class.getResource("/org/sonar/l10n/py/rules/python/Sonar_way_profile.json");
+    try {
+      Gson gson = new Gson();
+      return gson.fromJson(Resources.toString(profileUrl, StandardCharsets.UTF_8), Profile.class).ruleKeys;
+    } catch (IOException e) {
+      throw new IllegalStateException("Failed to read: " + profileUrl, e);
+    }
+  }
+
+  private static class Profile {
+    Set<String> ruleKeys;
   }
 }
diff --git a/sonar-python-plugin/src/test/java/org/sonar/plugins/python/PythonProfileTest.java b/sonar-python-plugin/src/test/java/org/sonar/plugins/python/PythonProfileTest.java
@@ -0,0 +1,63 @@
+/*
+ * SonarQube Python Plugin
+ * Copyright (C) 2011-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.plugins.python;
+
+import org.junit.Test;
+import org.mockito.invocation.InvocationOnMock;
+import org.mockito.stubbing.Answer;
+import org.sonar.api.profiles.RulesProfile;
+import org.sonar.api.rules.Rule;
+import org.sonar.api.rules.RuleFinder;
+import org.sonar.api.utils.ValidationMessages;
+import org.sonar.python.checks.CheckList;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Matchers.anyString;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class PythonProfileTest {
+
+  @Test
+  public void should_create_sonar_way_profile() {
+    ValidationMessages validation = ValidationMessages.create();
+
+    RuleFinder ruleFinder = ruleFinder();
+    PythonProfile definition = new PythonProfile(ruleFinder);
+    RulesProfile profile = definition.createProfile(validation);
+
+    assertThat(profile.getLanguage()).isEqualTo(Python.KEY);
+    assertThat(profile.getName()).isEqualTo(CheckList.SONAR_WAY_PROFILE);
+    assertThat(profile.getActiveRules()).extracting("repositoryKey").containsOnly(CheckList.REPOSITORY_KEY);
+    assertThat(validation.hasErrors()).isFalse();
+    assertThat(profile.getActiveRules().size()).isGreaterThan(25);
+  }
+
+  static RuleFinder ruleFinder() {
+    return when(mock(RuleFinder.class).findByKey(anyString(), anyString())).thenAnswer(new Answer<Rule>() {
+      @Override
+      public Rule answer(InvocationOnMock invocation) {
+        Object[] arguments = invocation.getArguments();
+        return Rule.create((String) arguments[0], (String) arguments[1], (String) arguments[1]);
+      }
+    }).getMock();
+  }
+
+}
