Skip to content

Commit 4bcbf70

Browse files
ximinezximinez
authored
chore: change Github Action triggers for build/test jobs (XRPLF#4956)
Github Actions for the build/test jobs (nix.yml, mac.yml, windows.yml) will only run on branches that build packages (develop, release, master), and branches with names starting with "ci/". This is intended as a compromise between disabling CI jobs on personal forks entirely, and having the jobs run as a free-for-all. Note that it will not affect PR jobs at all.
1 parent 61672ad commit 4bcbf70

File tree

4 files changed

+42
-3
lines changed

4 files changed

+42
-3
lines changed

‎.github/pull_request_template.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
<!--
22
This PR template helps you to write a good pull request description.
33
Please feel free to include additional useful information even beyond what is requested below.
4+
5+
If your branch is on a personal fork and has a name that allows it to
6+
run CI build/test jobs (e.g. "ci/foo"), remember to rename it BEFORE
7+
opening the PR. This avoids unnecessary redundant test runs. Renaming
8+
the branch after opening the PR will close the PR.
9+
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch
410
-->
511

612
## High Level Overview of Change

‎.github/workflows/macos.yml‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
name: macos
2-
on: [push, pull_request]
2+
on:
3+
pull_request:
4+
push:
5+
# If the branches list is ever changed, be sure to change it on all
6+
# build/test jobs (nix, macos, windows)
7+
branches:
8+
# Always build the package branches
9+
- develop
10+
- release
11+
- master
12+
# Branches that opt-in to running
13+
- 'ci/**'
314
concurrency:
415
group: ${{ github.workflow }}-${{ github.ref }}
516
cancel-in-progress: true

‎.github/workflows/nix.yml‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
name: nix
2-
on: [push, pull_request]
2+
on:
3+
pull_request:
4+
push:
5+
# If the branches list is ever changed, be sure to change it on all
6+
# build/test jobs (nix, macos, windows)
7+
branches:
8+
# Always build the package branches
9+
- develop
10+
- release
11+
- master
12+
# Branches that opt-in to running
13+
- 'ci/**'
314
concurrency:
415
group: ${{ github.workflow }}-${{ github.ref }}
516
cancel-in-progress: true

‎.github/workflows/windows.yml‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
name: windows
22

3-
on: [push, pull_request]
3+
on:
4+
pull_request:
5+
push:
6+
# If the branches list is ever changed, be sure to change it on all
7+
# build/test jobs (nix, macos, windows)
8+
branches:
9+
# Always build the package branches
10+
- develop
11+
- release
12+
- master
13+
# Branches that opt-in to running
14+
- 'ci/**'
415

516
# https://docs.github.com/en/actions/using-jobs/using-concurrency
617
concurrency:

0 commit comments

Comments
 (0)