Use shortcuts.redirect instead of HttpResponseRedirect.

bmispelon · bmispelon · commit ddc97b0488a6 · 2014-07-04T18:31:10.000+02:00
diff --git a/django_forms/README.md b/django_forms/README.md
@@ -183,13 +183,13 @@ Basically we have two things here: we save the form with `form.save` and we add
 Finally, it would be awesome if we can immediatelly go to `post_detail` page for newly created blog post, right? To do that we need more imports:
 
     from django.core.urlresolvers import reverse
-    from django.http import HttpResponseRedirect
+    from django.shortcuts import redirect
 
 Add them at the very beginning of your file. And now we can say: go to `post_detail` page for a post.
 
-    return HttpResponseRedirect(reverse(post_detail, kwargs={'pk': post.pk}))
+    return redirect('blog.views.post_detail', pk=post.pk)
 
-`post_detail` is a name of the view we want to go to. Remember that this view required a `pk` variable? To pass it to the views we use `kwargs={'pk': post.pk}`, where post is newly created blog post!
+`blog.views.post_detail` is a name of the view we want to go to. Remember that this view required a `pk` variable? To pass it to the views we use `pk=post.pk`, where post is newly created blog post!
 
 Ok, we talked a lot, but we probably would like to see how the whole view looks like, right?
 
@@ -200,7 +200,7 @@ Ok, we talked a lot, but we probably would like to see how the whole view looks
                 post = form.save(commit=False)
                 post.author = request.user
                 post.save()
-                return HttpResponseRedirect(reverse(post_detail, kwargs={'pk': post.pk}))
+                return redirect('blog.views.post_detail', pk=post.pk)
         else:
             form = PostForm()
         return render(request, 'blog/post_edit.html', {'form': form})
@@ -256,7 +256,7 @@ Let's open a `blog/views.py` and add at the very end of the file:
                 post = form.save(commit=False)
                 post.author = request.user
                 post.save()
-                return HttpResponseRedirect(reverse(post_detail, kwargs={'pk': post.pk}))
+                return redirect('blog.views.post_detail', pk=post.pk)
         else:
             form = PostForm(instance=post)
         return render(request, 'blog/post_edit.html', {'form': form})
diff --git a/homework_add_more_to_your_website/README.md b/homework_add_more_to_your_website/README.md
@@ -73,7 +73,7 @@ and finally, a view (as always, in `blog/views.py`):
     def post_publish(request, pk):
         post = get_object_or_404(Post, pk=pk)
         post.publish()
-        return HttpResponseRedirect(reverse(post_detail, kwargs={'pk': pk}))
+        return redirect('blog.views.post_detail', pk=pk)
 
 Remember, when we created a `Post` model we wrote a method `publish`. It looked like this:
 
@@ -106,11 +106,11 @@ Now, time for a view! Open `blog/views.py` and add this code:
     def post_remove(request, pk):
         post = get_object_or_404(Post, pk=pk)
         post.delete()
-        return HttpResponseRedirect(reverse(post_list))
+        return redirect('blog.views.post_list')
 
 The only new thing is to actually delete a post. Every Django model can be deleted by `.delete()`. It is as simple as that!
 
-And this time, after deleting a post we want to go to the webpage with a list of posts, so we are using `HttpResponseRedirect`.
+And this time, after deleting a post we want to go to the webpage with a list of posts, so we are using `redirect`.
 
 Let's test it! Go to the page with a post and try to delete it!
 
