Merge pull request HackYourFuture#163 from remarcmij/class19

remarcmij · web-flow · commit fa8725a5c69e · 2019-01-14T14:27:51.000+01:00
Class19 preparation
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -8,6 +8,13 @@
     "prettier/prettier": ["error"],
     "class-methods-use-this": "off",
     "strict": "off",
-    "no-plusplus": "off"
+    "no-plusplus": "off",
+    "linebreak-style": "off",
+    "no-param-reassign": [
+      "error",
+      {
+        "props": false
+      }
+    ]
   }
 }
diff --git a/homework/Util.js b/homework/Util.js
@@ -8,7 +8,7 @@ class Util {
     Object.keys(options).forEach(key => {
       const value = options[key];
       if (key === 'text') {
-        elem.innerText = value;
+        elem.textContent = value;
       } else {
         elem.setAttribute(key, value);
       }
diff --git a/homework/index.js b/homework/index.js
@@ -22,7 +22,7 @@
     Object.keys(options).forEach(key => {
       const value = options[key];
       if (key === 'text') {
-        elem.innerText = value;
+        elem.textContent = value;
       } else {
         elem.setAttribute(key, value);
       }
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "description": "GitHub API application",
   "scripts": {
-    "lint": "eslint homework --fix",
+    "lint": "eslint homework",
     "test": "npm run lint"
   },
   "author": "Jim Cramer",

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ class Util {`
`8`	`8`	`Object.keys(options).forEach(key => {`
`9`	`9`	`const value = options[key];`
`10`	`10`	`if (key === 'text') {`
`11`		`- elem.innerText = value;`
	`11`	`+ elem.textContent = value;`
`12`	`12`	`} else {`
`13`	`13`	`elem.setAttribute(key, value);`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`Object.keys(options).forEach(key => {`
`23`	`23`	`const value = options[key];`
`24`	`24`	`if (key === 'text') {`
`25`		`- elem.innerText = value;`
	`25`	`+ elem.textContent = value;`
`26`	`26`	`} else {`
`27`	`27`	`elem.setAttribute(key, value);`
`28`	`28`	`}`