refactor(sw): Delete the service worker manifest generation functionality from the CLI (angular#609)

alxhub · alxhub · commit 44e300bcd063 · 2016-05-03T01:02:08.000-06:00
diff --git a/README.md b/README.md
@@ -183,21 +183,7 @@ You can modify the these scripts in `package.json` to run whatever tool you pref
 
 ### Support for offline applications
 
-By default a file `manifest.appcache` will be generated which lists all files included in
-a project's output, along with SHA1 hashes of all file contents. This file can be used
-directly as an AppCache manifest (for now, `index.html` must be manually edited to set this up).
-
-The manifest is also annotated for use with `angular2-service-worker`. Some manual operations
-are currently required to enable this usage. The package must be installed, and `worker.js`
-manually copied into the project `src` directory:
-
-```bash
-npm install angular2-service-worker
-cp node_modules/angular2-service-worker/dist/worker.js src/
-```
-
- Then, the commented snippet in `index.html` must be uncommented to register the worker script
- as a service worker.
+The index.html file includes a commented-out code snippet for installing the angular2-service-worker. This support is experimental, please see the angular/mobile-toolkit project for documentation on how to make use of this functionality.
 
 ### Commands autocompletion
 
diff --git a/lib/broccoli/angular2-app.js b/lib/broccoli/angular2-app.js
@@ -6,7 +6,6 @@ const isProduction = require('./is-production');
 const BroccoliPlugin = require('broccoli-writer');
 const BroccoliConfigReplace = require('./broccoli-config-replace');
 const BroccoliTypescript = require('./broccoli-typescript');
-const BroccoliSwManifest = require('./service-worker-manifest').default;
 const BundlePlugin = require('./angular-broccoli-bundle');
 const BroccoliFunnel = require('broccoli-funnel');
 const BroccoliMergeTrees = require('broccoli-merge-trees');
@@ -136,7 +135,6 @@ class Angular2App extends BroccoliPlugin {
 
     if (isProduction) {
       merged = this._getBundleTree(merged);
-      merged = new BroccoliMergeTrees([merged, new BroccoliSwManifest([merged])]);
     }
 
     return new BroccoliFunnel(merged, {
diff --git a/lib/broccoli/service-worker-manifest.js b/lib/broccoli/service-worker-manifest.js
diff --git a/tests/e2e/e2e_workflow.spec.js b/tests/e2e/e2e_workflow.spec.js
@@ -72,17 +72,6 @@ describe('Basic end-to-end Workflow', function () {
     expect(sh.exec('git status --porcelain').output).to.be.equal(undefined);
   });
 
-  it('Produces a service worker manifest after production build', function () {
-    var manifestPath = path.join(process.cwd(), 'dist', 'manifest.appcache');
-    expect(existsSync(manifestPath)).to.be.equal(true);
-    // Read the worker.
-    //TODO: Commenting this out because it makes eslint fail(need to figure out why this expect was commented out)
-    // var lines = fse.readFileSync(manifestPath, {encoding: 'utf8'}).trim().split('\n');
-
-    // Check that a few critical files have been detected.
-    // expect(lines).to.include(`${path.sep}index.html`);
-  });
-
   it('Can run `ng build` in created project', function () {
     this.timeout(420000);
 
