complete binary:first/1 binary:last/1 TODO

vans163 · vans163 · commit c87289307137 · 2017-09-06T18:40:38.000-04:00
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
@@ -10,12 +10,16 @@ function copy(subject, n = 1) {
 }
 
 function first(subject) {
-  //TODO: raise badarg on size 0
+  if (subject.length == 0) {
+    throw new Error(`Binary is of length 0`);
+  }
   return at(subject, 0);
 }
 
 function last(subject) {
-  //TODO: raise badarg on size 0
+  if (subject.length == 0) {
+    throw new Error(`Binary is of length 0`);
+  }
   return subject.slice(-1);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,16 @@ function copy(subject, n = 1) {`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`function first(subject) {`
`13`		`- //TODO: raise badarg on size 0`
	`13`	`+ if (subject.length == 0) {`
	`14`	+ throw new Error(`Binary is of length 0`);
	`15`	`+ }`
`14`	`16`	`return at(subject, 0);`
`15`	`17`	`}`
`16`	`18`
`17`	`19`	`function last(subject) {`
`18`		`- //TODO: raise badarg on size 0`
	`20`	`+ if (subject.length == 0) {`
	`21`	+ throw new Error(`Binary is of length 0`);
	`22`	`+ }`
`19`	`23`	`return subject.slice(-1);`
`20`	`24`	`}`
`21`	`25`