Fix test and add test for unknown property

Sascha Hagedorn · Sascha Hagedorn · commit b3d8853f46ac · 2020-03-27T15:20:59.000+01:00
diff --git a/src/main/java/com/cleancoder/args/ArgsMain.java b/src/main/java/com/cleancoder/args/ArgsMain.java
@@ -1,11 +1,17 @@
 package com.cleancoder.args;
 
+import java.util.Arrays;
+import java.util.List;
+
 public class ArgsMain {
 
+    private final List<String> givenArgs;
+
     public ArgsMain(String[] givenArgs) {
+        this.givenArgs = Arrays.asList(givenArgs);
     }
 
     boolean isHelp() {
-        return true;
+        return givenArgs.contains("-h");
     }
 }
diff --git a/src/test/java/com/cleancoder/args/ArgsTest.java b/src/test/java/com/cleancoder/args/ArgsTest.java
@@ -3,12 +3,12 @@
 import org.assertj.core.util.Arrays;
 import org.junit.Test;
 
-import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.*;
 
 public class ArgsTest {
 
   @Test
-  public void testCreateWithNoSchemaOrArguments() {
+  public void detectWhenHelpIsRequested() {
     ArgsMain args = new ArgsMain(Arrays.array("-h"));
 
     boolean helpRequested = args.isHelp();
@@ -24,4 +24,9 @@ public void detectWhenHelpIsNotRequested() {
 
     assertThat(helpRequested).isFalse();
   }
+
+  @Test
+  public void shouldThrowIllegalArgumentExceptionOnUnknownArg() {
+    assertThatIllegalArgumentException().isThrownBy(() -> new ArgsMain(Arrays.array("-u")));
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,17 @@`
`1`	`1`	`package com.cleancoder.args;`
`2`	`2`
	`3`	`+import java.util.Arrays;`
	`4`	`+import java.util.List;`
	`5`	`+`
`3`	`6`	`public class ArgsMain {`
`4`	`7`
	`8`	`+ private final List<String> givenArgs;`
	`9`	`+`
`5`	`10`	`public ArgsMain(String[] givenArgs) {`
	`11`	`+ this.givenArgs = Arrays.asList(givenArgs);`
`6`	`12`	`}`
`7`	`13`
`8`	`14`	`boolean isHelp() {`
`9`		`- return true;`
	`15`	`+ return givenArgs.contains("-h");`
`10`	`16`	`}`
`11`	`17`	`}`