Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AAChartModel/AAChartKit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: AAChartModel/AAChartKit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 34 files changed
  • 1 contributor

Commits on Mar 17, 2026

  1. Add UI test hooks and macOS build support

    Enable macOS/Catalyst test/build settings and add UI test entry points for BasicChartVC.
    
    - Update Xcode project configs: set MACOSX_DEPLOYMENT_TARGET to 13.0, add CODE_SIGN_STYLE/DEVELOPMENT_TEAM and macOS-specific BUNDLE_LOADER/TEST_HOST entries, and mark UITests as supporting macOS/catalyst.
    - AppDelegate: import BasicChartVC and add aa_createUITestRootViewController to allow launching the BasicChart screen via -UITestBasicChartType launch arguments (returns a UINavigationController with the configured BasicChartVC).
    - BasicChartVC: add accessibilityIdentifier values to the view, chart view, controls, segmented controls, switches and navigation button to make UI elements addressable from tests.
    - UI Tests: refactor AAChartKitUITests to include an XCUIApplication property, add helper aa_launchBasicChartWithType: to launch with the test argument, and add tests for column and line chart layouts/interactions that use the new accessibility identifiers.
    
    These changes make it possible to run deterministic UI tests against BasicChartVC across platforms and Catalyst by launching the app directly into that view and locating controls via identifiers.
    AAChartModel committed Mar 17, 2026
    Configuration menu
    Copy the full SHA
    885e529 View commit details
    Browse the repository at this point in the history
  2. Expose chart state to UI tests and extend UITests

    Add a lightweight accessibility probe view (basic-chart.state) and a launch-argument flag (-UITestExposeChartState) to BasicChartVC to expose a serialized chart state for UI tests. Implement serialization and update the probe on draw/refresh/controls changes. Update UITests: rename/enhance a basic-chart test to exercise stacking, corner, and switch controls, add helpers to launch with the new flag, read/parse the JSON state, and assert state changes reliably. This enables more comprehensive, deterministic UI tests for chart configuration.
    AAChartModel committed Mar 17, 2026
    Configuration menu
    Copy the full SHA
    cbd16d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2026

  1. Expose chart state and detect series step

    Rename and refactor UITest root creation, default invalid chart types to Column, and add support for exposing additional chart state used by UI tests. BasicChartVC: include markerSymbol and markerRadius in serialized state, handle nil serialization, and add aa_seriesHasStep to indicate whether any series uses step. Update unit tests to import BasicChartComposer and add multiple tests verifying chart-type conversion, model configuration, marker/series settings and step flags. Update UI tests to expose chart state, assert navigation titles, and add a new test that verifies cycling chart types and the seriesHasStep state.
    AAChartModel committed Mar 26, 2026
    Configuration menu
    Copy the full SHA
    3fe3513 View commit details
    Browse the repository at this point in the history
  2. Refactor iOS13 helpers & fix type issues

    Add iOS13 helper functions and use them for table style and system symbol images (AASidebarListTableStyle, AASystemSymbolImageNamed) and tighten AppDelegate initializers/availability handling. Clean up demos by fixing types and API usages: replace AATitle with AAAxisTitle for axis titles, normalize boolean/NSNull usages (use true/false and (id)NSNull.null), cast gradient/color/size values to (id) where required, convert some JS template strings to concatenation, and replace a margin dictionary with an array. Also remove an unused bandId, adjust activity indicator style for iOS13, and simplify the XIB deployment tag. These changes correct type mismatches and improve runtime compatibility across iOS versions.
    AAChartModel committed Mar 26, 2026
    Configuration menu
    Copy the full SHA
    d7dd41f View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2026

  1. Improve macCatalyst sidebar UI and resizing

    Add a custom AASidebarCell and modernize sidebar visuals & interactions for macCatalyst: reuse blur/selection/stroke/highlight views, add hover pointer support, and adapt colors to trait changes. Introduce draggable divider with pan gesture and pointer cursor, enforce sidebar min/max widths, persist user-resized width (avoid auto-resize while dragging), and expose Cmd+Shift+L keyboard shortcut to toggle the sidebar. Also adjust container visuals (gradients, shadows, overlays), replace custom symbol helper calls with UIImage systemImageNamed for tab items, and remove deprecated UITest root creation and unused BasicChart import. Overall changes improve UX, performance and Dark Mode behavior for the sidebar.
    AAChartModel committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    2958a6a View commit details
    Browse the repository at this point in the history
  2. Add iOS13 dark mode support to list VC and cell

    Use iOS 13 dynamic system colors throughout the list: add a mainTableView property, set view and table background to systemBackgroundColor (fall back to white for <iOS13), and alternate rows use secondarySystemBackgroundColor. Update cell label colors to use UIColor labelColor/secondaryLabelColor in CustomTableViewCell.awakeFromNib and adapt titleLabel color in cellForRow. Implement traitCollectionDidChange and aa_updateDynamicColors to reload the table when the color appearance changes. All changes preserve legacy colors for pre-iOS13 devices.
    AAChartModel committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    2551bbc View commit details
    Browse the repository at this point in the history
  3. Support dark theme mode

    Replace hardcoded white backgrounds with UIColor.systemBackgroundColor (and secondarySystemBackgroundColor for alternating rows) when available to support Dark Mode. Update cell text colors to use UIColor.labelColor and UIColor.secondaryLabelColor on iOS13+. Avoid forcing navigation bar tint on iOS13. Changes affect AAChartModelListVC, AAOptionsComposerChartListVC, AAOptionsWithJSForChartEventsListVC, MainVC, and OfficialSamplesListVC while preserving legacy colors for older iOS versions.
    AAChartModel committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    5448369 View commit details
    Browse the repository at this point in the history
  4. Improve table cell styling and selection behavior

    Refactor table cell appearance and selection handling: use tertiaryLabelColor for subtitles on iOS13+, set explicit title/subtitle colors for pre-iOS13, and simplify alternating background logic with a ternary expression. Auto-deselect rows in didSelectRowAtIndexPath for better UX. Enhance CustomTableViewCell: style number badge as a pill, set consistent fonts and text colors, and preserve the badge background color during selection/highlight to avoid visual flicker.
    AAChartModel committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    503e3a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2026

  1. Revamp list UI: grouped headers and themed cells

    Redesign list/table appearance and theming across demo view controllers. Section headers were replaced with floating, rounded 'card' headers that use diagonal gradients, colored shadows, decorative translucent circles and a numeric badge. Tables now use grouped/system backgrounds on iOS13 with a light fallback, consistent separator insets/color, increased header height, dynamic row heights and automatic dimension. CustomTableViewCell gained a sectionColor property, an accent bar, a diagonal gradient badge, updated typography, and layout code to preserve colors during selection/highlight. Added a small color helper (aa_lightenColor) and minor behavior tweaks (row deselecting). Files changed: AAChartModelListVC.m, MainVC.m, AABaseListVC.m, CustomTableViewCell.h/.m.
    AAChartModel committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    1b68b0e View commit details
    Browse the repository at this point in the history
  2. Move badge gradient to background view

    Introduce badgeBackgroundView to host the diagonal CAGradientLayer instead of adding the gradient directly to numberLabel. numberLabel is made transparent and sits above the gradient; its font/color/alignment are configured on the label. badgeBackgroundView is inserted below the label and its frame (and the gradient's frame) is kept in sync with the label. Also simplify selection/highlight handling to preserve the accent bar color (removed temporary badge background color saves). This avoids clipping and improves gradient rendering for the numeric badge.
    AAChartModel committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    57f79d6 View commit details
    Browse the repository at this point in the history
  3. Lay out chart views with UIStackView & Auto Layout

    Replace manual frame-based positioning of the two AAChartView instances with a vertical UIStackView anchored to the view's safeAreaLayoutGuide. Chart views are now created with -init (no explicit frames) and added to the stack, which distributes them equally and uses Auto Layout constraints for top/bottom/leading/trailing. Removed the per-chart addSubview/frame code to enable responsive, safe-area-aware layout.
    AAChartModel committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    194faaa View commit details
    Browse the repository at this point in the history
  4. Use UIStackView and Auto Layout for charts

    Replace manual frame-based layout for the two AAChartView instances with a vertical UIStackView pinned to the view's safeAreaLayoutGuide. AAChartViews are now instantiated without explicit frames and assigned to _aaChartView1/_aaChartView2; the stack view distributes them equally to fill the safe area. Removed the individual addSubview calls and manual frame calculations to improve Auto Layout/safe-area handling and responsiveness.
    AAChartModel committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    dcd674f View commit details
    Browse the repository at this point in the history
  5. Use UIStackView and Auto Layout for charts

    Replace manual frame-based layout for the three AAChartView instances with a vertical UIStackView constrained to the view's safeAreaLayoutGuide. Initialize chart views without frames and let the stack view manage their sizing (distribution = FillEqually). Removed individual addSubview/frame math (including the hardcoded offsets), improving layout adaptability to rotations and safe areas; existing chart setup handlers and scrollEnabled = NO remain unchanged.
    AAChartModel committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    2adb523 View commit details
    Browse the repository at this point in the history
Loading