Skip to content

chore(ci): upgrade to node 24#4189

Merged
grigoriy-reshetniak merged 2 commits intomainfrom
bump-ci-node-version
Mar 31, 2026
Merged

chore(ci): upgrade to node 24#4189
grigoriy-reshetniak merged 2 commits intomainfrom
bump-ci-node-version

Conversation

@grigoriy-reshetniak
Copy link
Copy Markdown
Collaborator

What is the previous behavior before this PR?
CI used node 20.

What is the new behavior after this PR?
CI use node 24.

Workflow checks:

  • Screenshotter
  • CI -- can't start manually, missing workflow_dispatch.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 31, 2026

Greptile Summary

This PR upgrades the Node.js runtime from version 20 to version 24 across all CI workflows. The change is applied consistently in every relevant location: both the test and release jobs in ci.yml, and both the actions/setup-node step and the Docker container image (node:24) in screenshotter.yml.

Key points:

  • The upgrade is consistent across all three locations in the two changed files.
  • No other workflow files (fonts.yml, codeql-analysis.yml) pin a Node.js version, so they don't need updating.
  • The package.json has no engines field, so no version constraint needs to be updated there either.
  • The node:24 Docker image tag in screenshotter.yml is floating (unpinned patch version), matching the pre-existing behavior of node:20.
  • The screenshotter workflow run has been verified by the author (linked run passes).
  • The pre-existing absence of workflow_dispatch in ci.yml is noted in the PR description and is not introduced by this change.

Confidence Score: 5/5

Safe to merge — this is a clean, consistent Node.js version bump with no logic changes and a verified screenshotter run.

All Node.js version references are updated consistently across both workflow files. No package.json engines constraint exists to drift. No other workflows pin a Node.js version. The screenshotter workflow (the more complex of the two) has been verified by the author. No P0 or P1 issues were found.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Node.js version bumped from 20 to 24 in both the test and release jobs; no other changes.
.github/workflows/screenshotter.yml Node.js version bumped from 20 to 24 in both the actions/setup-node step and the Docker image used to run the screenshotter container.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR[Pull Request / Push to main] --> CI[ci.yml: test job\nNode.js 24]
    CI -->|success| RELEASE[ci.yml: release job\nNode.js 24]
    PR --> SS[screenshotter.yml\nactions/setup-node: Node.js 24]
    SS --> DOCKER["Docker: node:24 container\nscreenshotter.js"]
    DOCKER --> BROWSERS["Matrix: chrome / firefox / safari"]
Loading

Reviews (1): Last reviewed commit: "chore(ci): upgrade to node 24" | Re-trigger Greptile

Copy link
Copy Markdown
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we add workflow_dispatch to CI here, to enable future testing?

@grigoriy-reshetniak grigoriy-reshetniak merged commit 434d4b8 into main Mar 31, 2026
8 checks passed
@grigoriy-reshetniak grigoriy-reshetniak deleted the bump-ci-node-version branch March 31, 2026 11:30
@edemaine
Copy link
Copy Markdown
Member

edemaine commented Apr 5, 2026

🎉 This PR is included in version 0.16.45 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants