Checkbox - add validation if no choice is selected#1316
Merged
SBoudrias merged 6 commits intoSBoudrias:masterfrom Oct 15, 2023
Merged
Checkbox - add validation if no choice is selected#1316SBoudrias merged 6 commits intoSBoudrias:masterfrom
SBoudrias merged 6 commits intoSBoudrias:masterfrom
Conversation
…e they were failing because of new validation logic
Codecov ReportAll modified lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
SBoudrias
reviewed
Oct 8, 2023
Owner
SBoudrias
left a comment
There was a problem hiding this comment.
Thanks for the PR! Did a review pass and left you some comments. Let me know if you need more clairification!
…sts since they were failing because of new validation logic" This reverts commit 3b4e0e7.
…ible, fixed unit tests
Contributor
Author
|
FYI @SBoudrias, I started working on the second part of the issue (adding |
SBoudrias
reviewed
Oct 15, 2023
SBoudrias
approved these changes
Oct 15, 2023
Owner
SBoudrias
left a comment
There was a problem hiding this comment.
Great! Thanks for following up on all the comments. I'll get this merge ASAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1257 (first part)
Adds validation logic for checkbox component that notifies the user if no choice has been selected and presses
enter(enforces that at least one choice must be selected)Added unit test for new logic. Also needed to edit a few existing ones since they were failing because of this new feature.