Auto jump vars discovery and improve concrete typing#1372
Merged
isaacsas merged 2 commits intoSciML:version_16_newfrom Feb 4, 2026
Merged
Auto jump vars discovery and improve concrete typing#1372isaacsas merged 2 commits intoSciML:version_16_newfrom
isaacsas merged 2 commits intoSciML:version_16_newfrom
Conversation
Extend make_ReactionSystem_internal to discover variables from jumps, analogous to how events are handled. This allows users to pass jumps to the two-argument constructor without explicitly specifying all unknowns and parameters. - Add find_jump_vars! function using MT.collect_vars! for jump types - Add jumps kwarg to make_ReactionSystem_internal - Add tests for ConstantRateJump, VariableRateJump, and MassActionJump Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Type Dict keys in get_netstoich as eltype(subs) instead of Any
- Type empty Dicts as Dict{SymbolicT, SymbolicT}() for substitution maps
- Type reactant_stoch vector with SymbolicT keys
- Delete get_speciestype function, use SymbolicT directly
- Use CatalystEqType[] instead of Any[] for equation reduction init
- Type systems field as Vector{ReactionSystem}
- Type parent field as Union{Nothing, ReactionSystem}
- Remove unused connection_type field from ReactionSystem struct
- Update tests for new Reaction type parameter (SymbolicT instead of Any)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.