fix isdetailedbalanced tol issue#1376
Merged
isaacsas merged 1 commit intoSciML:version_16_newfrom Feb 5, 2026
Merged
Conversation
substitutevals was returning Symbolics Num-wrapped values even when
all parameters were substituted with concrete numeric values. This
caused adjacencymat, fluxmat, and massactionvector to return Matrix{Num}
instead of Matrix{Float64} when parameter maps were provided.
This triggered a bug in Symbolics.jl isapprox for Num types, which
incorrectly handles relative tolerance. This caused isdetailedbalanced
to fail with abstol=0 even for systems that satisfy detailed balance.
The fix unwraps the substitution result with value(), so these functions
now correctly return numeric types as documented. This also restores
isdetailedbalanced to use abstol=0 with proper rtol behavior.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
substitutevalsto return numeric types instead ofNumProblem
isdetailedbalancedwas failing withabstol=0for systems that mathematically satisfy detailed balance, requiringabstol=1e-12as a workaround.Root Cause
substitutevalsreturned SymbolicsNum-wrapped values even when substituting concrete numbers. This causedadjacencymatto returnMatrix{Num}instead ofMatrix{Float64}, triggering a bug in Symbolics.jl'sisapproxforNumtypes (it compareserrto0.0instead of comparing original values, breaking relative tolerance handling).Fix
Unwrap substitution results with
value()soadjacencymat,fluxmat, andmassactionvectorcorrectly return numeric types when parameter maps are provided (as their docstrings already promised).Testing
All 168 tests in
crn_theory.jlandnetwork_properties.jlpass.