Skip to content

chore: Create check-dist.yml#96

Merged
Swatinem merged 1 commit intoSwatinem:masterfrom
jongwooo:chore/add-check-dist-workflow
Dec 17, 2022
Merged

chore: Create check-dist.yml#96
Swatinem merged 1 commit intoSwatinem:masterfrom
jongwooo:chore/add-check-dist-workflow

Conversation

@jongwooo
Copy link
Copy Markdown
Contributor

Description

This adds a workflow to check the contents of the checked-in dist/ against the expected version.

See actions/upload-artifact#227 for background and rationale.

@Swatinem
Copy link
Copy Markdown
Owner

I’m a bit undecided on this.

I tend to merge things without the dist changes, as reviewing those is impossible, and I would rather build things myself so I know they are correct.

On the other hand this action explicitly makes sure that whatever is being committed to dist is reproducible. 🤔

@jongwooo
Copy link
Copy Markdown
Contributor Author

@Swatinem I fully support your decision:)

@Swatinem Swatinem merged commit 664ce00 into Swatinem:master Dec 17, 2022
@jongwooo jongwooo deleted the chore/add-check-dist-workflow branch December 17, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants