Remove unnecessary import that confuses type checkers#3624
Merged
willmcgugan merged 1 commit intoTextualize:masterfrom Mar 30, 2025
Merged
Remove unnecessary import that confuses type checkers#3624willmcgugan merged 1 commit intoTextualize:masterfrom
willmcgugan merged 1 commit intoTextualize:masterfrom
Conversation
nakowafers
approved these changes
Feb 7, 2025
Member
|
I think pyre is in the wrong here, but ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
in
rich.table, when executed as a main script, it importsTablefrom itself.this seems unnecessary, considering the
Tableclass is implemented in the same module.this isn't only cosmetic though - at least one type checker (Pyre) gets confused because of this, and treats
Tableas a symbol that isn't exported byrich.table.please let me know if this change is acceptable, and if so, whether it needs a CHANGELOG entry and/or additional tests.