Skip to content

Remove chardet/charset-normalizer.#7589

Merged
Dreamsorcerer merged 10 commits intoaio-libs:3.8from
john-parton:patchback/backports/3.8/675579699422680607108a7dd68c85ec5284220c/pr-7561
Sep 9, 2023
Merged

Remove chardet/charset-normalizer.#7589
Dreamsorcerer merged 10 commits intoaio-libs:3.8from
john-parton:patchback/backports/3.8/675579699422680607108a7dd68c85ec5284220c/pr-7561

Conversation

@john-parton
Copy link
Copy Markdown
Contributor

@john-parton john-parton commented Sep 7, 2023

Add fallback_charset_resolver ClientSession parameter. (#7561)

Co-authored-by: Sam Bull [email protected]
(cherry picked from commit 6755796)

…ntSession parameter. (aio-libs#7561)

Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 6755796)
@john-parton
Copy link
Copy Markdown
Contributor Author

john-parton commented Sep 7, 2023

@Dreamsorcerer Here's that PR we discussed.

Looks like this isn't quite ready. The code and tests should be correct, but I haven't got the docs updated.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2023

Codecov Report

Merging #7589 (3a53d00) into 3.8 (5946c74) will decrease coverage by 0.02%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##              3.8    #7589      +/-   ##
==========================================
- Coverage   97.38%   97.37%   -0.02%     
==========================================
  Files         107      107              
  Lines       31056    31049       -7     
  Branches     3937     3940       +3     
==========================================
- Hits        30243    30233      -10     
- Misses        608      610       +2     
- Partials      205      206       +1     
Flag Coverage Δ
CI-GHA 97.23% <96.42%> (-0.02%) ⬇️
OS-Linux 96.89% <96.42%> (+<0.01%) ⬆️
OS-Windows 95.21% <94.73%> (-0.01%) ⬇️
OS-macOS 96.61% <96.42%> (-0.03%) ⬇️
Py-3.10.11 94.82% <94.73%> (+<0.01%) ⬆️
Py-3.10.13 96.53% <96.42%> (+0.05%) ⬆️
Py-3.11.0 96.16% <96.42%> (+<0.01%) ⬆️
Py-3.6.15 96.35% <96.42%> (-0.02%) ⬇️
Py-3.6.8 94.73% <94.73%> (-0.01%) ⬇️
Py-3.7.17 96.56% <96.42%> (+0.04%) ⬆️
Py-3.7.9 94.86% <94.73%> (-0.01%) ⬇️
Py-3.8.10 94.79% <94.73%> (-0.01%) ⬇️
Py-3.8.18 96.42% <96.42%> (-0.01%) ⬇️
Py-3.9.13 94.79% <94.73%> (-0.01%) ⬇️
Py-3.9.17 ?
Py-3.9.18 96.44% <96.42%> (+0.02%) ⬆️
Py-pypy7.3.11 93.88% <92.85%> (-0.01%) ⬇️
VM-macos-latest 96.61% <96.42%> (-0.03%) ⬇️
VM-ubuntu-20.04 96.87% <96.42%> (+0.04%) ⬆️
VM-ubuntu-latest 96.38% <96.42%> (-0.01%) ⬇️
VM-windows-latest 95.21% <94.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiohttp/client_reqrep.py 97.33% <91.66%> (-0.18%) ⬇️
aiohttp/client.py 94.43% <100.00%> (+0.10%) ⬆️
tests/test_client_response.py 99.12% <100.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer changed the title Remove chardet/charset-normalizer. Add fallback_charset_resolver Clie… Remove chardet/charset-normalizer. Sep 8, 2023
Comment thread aiohttp/client.py Outdated
@john-parton john-parton force-pushed the patchback/backports/3.8/675579699422680607108a7dd68c85ec5284220c/pr-7561 branch from e530e2a to 2f43204 Compare September 8, 2023 19:56
Comment thread aiohttp/client.py Outdated
Comment thread docs/client_advanced.rst Outdated
Comment thread docs/client_advanced.rst Outdated
Comment thread docs/client_reference.rst Outdated
Comment thread docs/client_reference.rst Outdated
Comment thread docs/client_reference.rst Outdated
Comment thread docs/client_reference.rst
Comment thread aiohttp/client.py Outdated
@Dreamsorcerer Dreamsorcerer reopened this Sep 9, 2023
@Dreamsorcerer
Copy link
Copy Markdown
Member

OK, looks like it's ready. That should auto-merge, then we just need the final PR.

@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) September 9, 2023 11:21
@Dreamsorcerer Dreamsorcerer merged commit b30c0cd into aio-libs:3.8 Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants