Avoid running logical line rule logic if not enabled#11951
Merged
dhruvmanila merged 2 commits intomainfrom Jun 20, 2024
Merged
Conversation
Contributor
|
MichaReiser
approved these changes
Jun 20, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks for doing this. This might improve performance, it just won't show in our benchmarks because we either run all or no logical line rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the logical line rules entry-point function to only run the logic if any of the rules within that group is enabled.
Although this shouldn't really give any performance improvements, it's better not to do additional work if we can. This is also consistent with how other rules are run.
Test Plan
cargo insta test