feat(ses): event destinations for configuration sets#24745
feat(ses): event destinations for configuration sets#24745mergify[bot] merged 8 commits intoaws:mainfrom
Conversation
Add a L2 for `ConfigurationSetEventDestination`.
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Overall this is fantastic. Just a few small comments/questions inline.
| * | ||
| * @default true | ||
| */ | ||
| readonly enabled?: boolean; |
There was a problem hiding this comment.
Is there a use case for adding the destination and not enabling it? This seems unnecessary but maybe I'm missing something.
There was a problem hiding this comment.
Can be used in staging/dev/test environments where it can be "manually" enabled for testing purposes (so you don't pay for 100% of the time enabled in those environments).
| /** | ||
| * Use an existing configuration set | ||
| */ | ||
| public static fromConfigurationSetEventDestinationId( |
There was a problem hiding this comment.
Is there a case to also have a fromConfigurationSetEventDestinationName?
There was a problem hiding this comment.
The id is the name I think but the doc is not really clear...
Anyway I don't think this resource will be referenced by another CF resource, even the fromConfigurationSetEventDestinationId() will not be used I think... (but makes the linter happy)
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add a L2 for
ConfigurationSetEventDestination.Only Amazon SNS and Amazon CloudWatch have been implemented.
By default, the destination is enabled and all events are published.
Also add a
addEventDestination()convenience method toConfigurationSet.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license