feat(codepipeline-actions): support `ECRBuildAndPublish` action by go-to-k · Pull Request #33375 · aws/aws-cdk

go-to-k · 2025-02-11T07:22:47Z

Issue # (if applicable)

Closes #33376

Reason for this change

AWS CodePipeline introduces new build action: ECRBuildAndPublish action.

Description of changes

Add ECRBuildAndPublishAction class that extends Action class to aws-codepipeline-actions module.

Describe any new or updated permissions being added

Description of how you validated changes

Both unit and integ tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

codecov · 2025-02-11T07:35:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (217d75f) to head (b72e14d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33375   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112

Flag	Coverage Δ
suite.unit	`83.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`83.98% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation

(This review is outdated)

go-to-k · 2025-03-27T01:00:27Z

@Mergifyio requeue

mergify · 2025-03-27T01:00:35Z

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details

sender-permission >= write

go-to-k · 2025-03-27T01:01:27Z

@Mergifyio update

mergify · 2025-03-27T01:01:33Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

go-to-k · 2025-03-27T01:05:10Z

@Mergifyio refresh

mergify · 2025-03-27T01:05:13Z

refresh

✅ Pull request refreshed

mergify · 2025-03-27T01:05:49Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

go-to-k · 2025-03-27T01:06:30Z

@Mergifyio update

mergify · 2025-03-27T01:07:00Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

go-to-k · 2025-03-27T01:10:06Z

@Mergifyio refresh

mergify · 2025-03-27T01:10:10Z

refresh

✅ Pull request refreshed

mergify · 2025-03-27T01:10:46Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

go-to-k · 2025-03-27T01:11:13Z

@Mergifyio update

mergify · 2025-03-27T01:11:22Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

go-to-k · 2025-03-27T01:14:49Z

@GavinZZ

Hmmm... I'm not sure what to do.
What should I do in such a case? Shoud I just wait?

go-to-k · 2025-04-01T13:38:25Z

@Mergifyio update

mergify · 2025-04-01T13:38:37Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

go-to-k · 2025-04-01T18:10:18Z

@GavinZZ Could you please check this situation again?

GavinZZ · 2025-04-01T21:44:19Z

Sorry @go-to-k for the late response. I'll handle this PR.

Pull request has been modified.

mergify · 2025-04-01T22:14:51Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-04-01T22:45:05Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: b72e14d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-04-01T22:45:22Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-04-01T22:45:41Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(codepipeline-actions): support ECRBuildAndPublish build action

1f945a1

github-actions Bot added the p2 label Feb 11, 2025

aws-cdk-automation requested a review from a team February 11, 2025 07:23

github-actions Bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 11, 2025

aws-cdk-automation previously requested changes Feb 11, 2025

View reviewed changes

github-actions Bot added the feature-request A feature should be added or improved. label Feb 11, 2025

go-to-k added 3 commits February 11, 2025 17:01

comment

84e657b

comment

b865c6f

filename

1a4739d

go-to-k changed the title ~~feat(codepipeline-actions): support ECRBuildAndPublish build action~~ feat(codepipeline-actions): support ECRBuildAndPublish action Feb 11, 2025

go-to-k changed the title ~~feat(codepipeline-actions): support ECRBuildAndPublish action~~ feat(codepipeline-actions): support ECRBuildAndPublish action Feb 11, 2025

go-to-k added 8 commits February 11, 2025 19:04

index

0774008

integ

9598a61

integ snapshots

cd68351

dockerfileDirectoryPath

931b045

dockerfileDirectoryPath

fdee49c

coment

d8e43ca

integ and snapshots with MOCK

01adcec

unit tests

c58fa12

github-actions Bot added the effort/medium Medium work item – several days of effort label Feb 14, 2025

go-to-k added 2 commits February 14, 2025 20:41

var names in tests

2ef5217

README

f8fa02f

go-to-k marked this pull request as ready for review February 14, 2025 13:57

aws-cdk-automation previously requested changes Feb 14, 2025

View reviewed changes

rosetta

c647d70

revert rosseta

0f824ed

aws-cdk-automation previously requested changes Feb 14, 2025

View reviewed changes

Merge branch 'main' into cp-actions-ecr-build-publish

f8dcb31

GavinZZ approved these changes Apr 1, 2025

View reviewed changes

Merge branch 'main' into cp-actions-ecr-build-publish

b72e14d

mergify Bot merged commit c5cd679 into aws:main Apr 1, 2025
20 checks passed

github-actions Bot locked as resolved and limited conversation to collaborators Apr 1, 2025

go-to-k deleted the cp-actions-ecr-build-publish branch April 2, 2025 02:28

Conversation

go-to-k commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

mergify Bot commented Mar 27, 2025

❌ Command disallowed due to command restrictions in the Mergify configuration.

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

mergify Bot commented Mar 27, 2025

❌ Mergify doesn't have permission to update

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

mergify Bot commented Mar 27, 2025

✅ Pull request refreshed

Uh oh!

mergify Bot commented Mar 27, 2025

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

mergify Bot commented Mar 27, 2025

❌ Mergify doesn't have permission to update

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

mergify Bot commented Mar 27, 2025

✅ Pull request refreshed

Uh oh!

mergify Bot commented Mar 27, 2025

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

mergify Bot commented Mar 27, 2025

❌ Mergify doesn't have permission to update

Uh oh!

go-to-k commented Mar 27, 2025

Uh oh!

go-to-k commented Apr 1, 2025

Uh oh!

mergify Bot commented Apr 1, 2025

❌ Mergify doesn't have permission to update

Uh oh!

go-to-k commented Apr 1, 2025

Uh oh!

GavinZZ commented Apr 1, 2025

Uh oh!

mergify Bot commented Apr 1, 2025

Uh oh!

aws-cdk-automation commented Apr 1, 2025

AWS CodeBuild CI Report

Uh oh!

mergify Bot commented Apr 1, 2025

Uh oh!

Uh oh!

github-actions Bot commented Apr 1, 2025

go-to-k commented Feb 11, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov Bot commented Feb 11, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading