Skip to content

feat(events-targets): support ApiGatewayV2 HttpApi#33864

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
phuhung273:event-target-apigwv2
Apr 1, 2025
Merged

feat(events-targets): support ApiGatewayV2 HttpApi#33864
mergify[bot] merged 5 commits intoaws:mainfrom
phuhung273:event-target-apigwv2

Conversation

@phuhung273
Copy link
Copy Markdown
Contributor

@phuhung273 phuhung273 commented Mar 21, 2025 •
edited
Loading

Issue # (if applicable)

Closes #26649

Description of changes

Same logic as ApiGateway v1 target with some differences:

Feature v1 v2
_api interface api.IRestApi apigwv2.IHttpApi
default stage if not specified _restApi.deploymentStage.stageName _httpApi.defaultStage.stageName

Description of how you validated changes

Unit + Integ

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions Bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Mar 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 21, 2025 16:05
@github-actions github-actions Bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Mar 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (2cff67e) to head (4ff17eb).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33864   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         120      120           
  Lines        6975     6975           
  Branches     1178     1178           
=======================================
  Hits         5750     5750           
  Misses       1120     1120           
  Partials      105      105
Flag Coverage Δ
suite.unit 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.43% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 21, 2025
paulhcsun
paulhcsun previously requested changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a few comments for some minor changes.

Comment thread packages/aws-cdk-lib/aws-apigatewayv2/lib/http/api.ts Outdated
Comment thread packages/aws-cdk-lib/aws-events-targets/lib/api-gatewayv2.ts Outdated
Comment thread packages/aws-cdk-lib/aws-events-targets/lib/api-gatewayv2.ts Outdated
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 1, 2025
@github-actions github-actions Bot mentioned this pull request Apr 1, 2025
Closed
@mergify mergify Bot dismissed paulhcsun’s stale review April 1, 2025 04:20

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 1, 2025
@phuhung273 phuhung273 requested a review from paulhcsun April 1, 2025 12:28
@Creatur3245 Creatur3245 mentioned this pull request Apr 1, 2025
Open
@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Apr 1, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 1, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 1, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4ff17eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 1, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 91a3076 into aws:main Apr 1, 2025
22 of 23 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@phuhung273 phuhung273 deleted the event-target-apigwv2 branch April 1, 2025 17:28
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@paulhcsun paulhcsun paulhcsun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paulhcsun paulhcsun

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-events-targets): No target for ApiGatewayV2 HttpApi

3 participants

@phuhung273 @paulhcsun @aws-cdk-automation