Skip to content

fix(cx-api): adding missing readme#34003

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
IkeNefcy:restoringOrderPart3
Apr 2, 2025
Merged

fix(cx-api): adding missing readme#34003
mergify[bot] merged 3 commits intoaws:mainfrom
IkeNefcy:restoringOrderPart3

Conversation

@IkeNefcy
Copy link
Copy Markdown
Contributor

@IkeNefcy IkeNefcy commented Apr 1, 2025 •
edited
Loading

Issue

Closes #34006

Reason for this change

Readme was not added to #33983

Description of changes

Adding readme based on feature description

aws-cdk/packages/aws-cdk-lib/cx-api/README.md

Lines 698 to 714 in b577419

* `@aws-cdk/cognito:logUserPoolClientSecretValue`
When this feature flag is enabled, the SDK API call response to desribe user pool client values will be logged in the custom
resource lambda function logs.
When this feature flag is disabled, the SDK API call response to describe user pool client values will not be logged in the custom
resource lambda function logs.
_cdk.json_
```json
{
"context": {
"@aws-cdk/cognito:logUserPoolClientSecretValue": true
}
}
```

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 1, 2025 17:01
@github-actions github-actions Bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Apr 1, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (2ebc51e) to head (e48e613).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #34003   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IkeNefcy
Copy link
Copy Markdown
Contributor Author

IkeNefcy commented Apr 1, 2025

Exemption Request on both, just righting a wrong here

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 1, 2025
@IkeNefcy IkeNefcy marked this pull request as ready for review April 1, 2025 20:19
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 1, 2025
@QuantumNeuralCoder QuantumNeuralCoder added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Apr 2, 2025
@QuantumNeuralCoder QuantumNeuralCoder self-assigned this Apr 2, 2025
@QuantumNeuralCoder
Copy link
Copy Markdown
Contributor

QuantumNeuralCoder commented Apr 2, 2025

Exempting both. Please ensure ff documentation are included in the same PR henceforth. Thanks for this one.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 2, 2025 17:14

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 2, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e48e613
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 1c5cbfa into aws:main Apr 2, 2025
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 2, 2025
@IkeNefcy IkeNefcy deleted the restoringOrderPart3 branch October 14, 2025 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@QuantumNeuralCoder QuantumNeuralCoder QuantumNeuralCoder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@QuantumNeuralCoder QuantumNeuralCoder

Labels

p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cx-api: missing readme for ff @aws-cdk/cognito:logUserPoolClientSecretValue

3 participants

@IkeNefcy @QuantumNeuralCoder @aws-cdk-automation