Skip to content

fix(lambda): deprecate default feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy#34010

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
QuantumNeuralCoder:pr-33689-redone
Apr 2, 2025
Merged

fix(lambda): deprecate default feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy#34010
mergify[bot] merged 2 commits intoaws:mainfrom
QuantumNeuralCoder:pr-33689-redone

Conversation

@QuantumNeuralCoder
Copy link
Copy Markdown
Contributor

@QuantumNeuralCoder QuantumNeuralCoder commented Apr 2, 2025

deprecate default feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy
same as pr-33689

Issue # (if applicable)

Closes #33688 .

Reason for this change

same as #33689

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 2, 2025 00:27
@github-actions github-actions Bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Apr 2, 2025
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Apr 2, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (2dc8cc7) to head (c14f9bc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #34010   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumNeuralCoder
Copy link
Copy Markdown
Contributor Author

QuantumNeuralCoder commented Apr 2, 2025

exemption request

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Apr 2, 2025
@QuantumNeuralCoder QuantumNeuralCoder added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Apr 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 2, 2025 16:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 2, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c14f9bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 242091a into aws:main Apr 2, 2025
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 2, 2025
@QuantumNeuralCoder QuantumNeuralCoder deleted the pr-33689-redone branch May 14, 2025 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-lambda): deprecate feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy introduced in pr-33291

3 participants

@QuantumNeuralCoder @aws-cdk-automation @GavinZZ