fix(codepipeline): replace account root principal with pipeline role in trust policy for cross-account actions (under feature flag)#34074
Merged
mergify[bot] merged 8 commits intoaws:mainfrom Apr 8, 2025
Conversation
godwingrs22
approved these changes
Apr 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34074 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
GHSA-5pq3-h73f-66hr
Reason for this change
See GHSA for details.
Description of changes
Added new feature flag
@aws-cdk/pipelines:reduceCrossAccountActionRoleTrustScopeWhen the feature flag
@aws-cdk/pipelines:reduceCrossAccountActionRoleTrustScopeis set to true:roleNametoPhysicalName.GENERATE_IF_NEEDEDDescribe any new or updated permissions being added
Cross-account action role trust policy is scoped with condition key
ArnEqualswhen feature flag is enabled:Description of how you validated changes
Added integration tests for S3, StepFunction, and Cloudformation codepipeline actions and manually verified that the cross-account action was successfully completed (reading S3 bucket, invoking state machine, and deploying a cloudformation stack in the cross-account).
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license