fix(cli): flags command shows unnecessary flags, not all table rows have vertical lines#796
Merged
aws-cdk-automation merged 4 commits intoaws:mainfrom Aug 26, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 81.42% 80.88% -0.55%
==========================================
Files 63 63
Lines 8602 8599 -3
Branches 1034 1029 -5
==========================================
- Hits 7004 6955 -49
- Misses 1567 1615 +48
+ Partials 31 29 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
requested changes
Aug 14, 2025
Contributor
rix0rrr
left a comment
There was a problem hiding this comment.
Small comment.
Also, these 2 changes should probably be different PRs (though I'm guilty of combining changes into a single PR all the time as well 😈)
rix0rrr
requested changes
Aug 19, 2025
rix0rrr
reviewed
Aug 26, 2025
rix0rrr
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user runs
cdk flags, a table is displayed with information about their feature flags. This PR omits the intentionally unconfigured feature flags from the table and makes the table more visually appealing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license