Skip to content

fix(cli): when CDK library is too old, an empty flags table is displayed#797

Merged
vivian12300 merged 2 commits intoaws:mainfrom
vivian12300:compatible
Aug 14, 2025
Merged

fix(cli): when CDK library is too old, an empty flags table is displayed#797
vivian12300 merged 2 commits intoaws:mainfrom
vivian12300:compatible

Conversation

@vivian12300
Copy link
Copy Markdown
Contributor

Returns an error message for users if they run the cdk flags command with an incompatible version of aws-cdk-lib.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.49%. Comparing base (17ebf86) to head (ad8c508).
⚠️ Report is 283 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          63       63           
  Lines        8602     8608    +6     
  Branches     1036     1040    +4     
=======================================
+ Hits         7010     7015    +5     
+ Misses       1562     1560    -2     
- Partials       30       33    +3     
Flag Coverage Δ
suite.unit 81.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vivian12300 vivian12300 disabled auto-merge August 14, 2025 03:39
@rix0rrr rix0rrr changed the title feat: add notice when users run cdk flags with an incompatible version of the CDK Library fix(cli): when CDK library is too old, an empty flags table is displayed Aug 14, 2025
@vivian12300 vivian12300 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into aws:main with commit 98a1bfa Aug 14, 2025
27 checks passed
@vivian12300 vivian12300 deleted the compatible branch August 14, 2025 14:33
iankhou pushed a commit that referenced this pull request Aug 21, 2025
…yed (#797)

Returns an error message for users if they run the `cdk flags` command
with an incompatible version of `aws-cdk-lib`.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants