fix(cli): cdk flags --set without additional options should fail#833
Merged
aws-cdk-automation merged 3 commits intomainfrom Sep 3, 2025
Merged
fix(cli): cdk flags --set without additional options should fail#833aws-cdk-automation merged 3 commits intomainfrom
aws-cdk-automation merged 3 commits intomainfrom
Conversation
Signed-off-by: github-actions <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 83.05% 83.67% +0.61%
==========================================
Files 65 65
Lines 9509 9514 +5
Branches 1122 1136 +14
==========================================
+ Hits 7898 7961 +63
+ Misses 1577 1529 -48
+ Partials 34 24 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #832
Currently, running
cdk flags --setorcdk flags --set --recommendedis a no-op. Either the--allor--unconfiguredoptions should be passed alongside--set. This can be attributed to insufficient testing during development of the feature.Changes:
flag-operations.tsto 100% unit test line coverage (previously 92%)Validated with unit tests and manual testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license