fix: cdk flags outputs empty table when recommended flags are already set#836
Merged
aws-cdk-automation merged 1 commit intomainfrom Sep 8, 2025
Merged
fix: cdk flags outputs empty table when recommended flags are already set#836aws-cdk-automation merged 1 commit intomainfrom
aws-cdk-automation merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 83.68% 82.94% -0.74%
==========================================
Files 65 65
Lines 9547 9554 +7
Branches 1137 1122 -15
==========================================
- Hits 7989 7925 -64
- Misses 1535 1607 +72
+ Partials 23 22 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #834
Description
DX improvement.
Previously, when the user ran
cdk flagsbut already had all recommended flags configured, an empty table was displayed.No context here, what does the table mean?
In this change, we added a message to inform the user why they are seeing an empty table. We still print the table to maintain API consistency.
Now the user knows why the table is empty, and is given guidance to display all flags
Testing
Added unit tests for positive and negative cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license