feat: add a mechanism to retrieve all context (with defaults)#1751
Merged
mergify[bot] merged 3 commits intoaws:10.xfrom Oct 7, 2023
Merged
feat: add a mechanism to retrieve all context (with defaults)#1751mergify[bot] merged 3 commits intoaws:10.xfrom
mergify[bot] merged 3 commits intoaws:10.xfrom
Conversation
mrgrain
approved these changes
Oct 7, 2023
Contributor
|
Apologies for the delay @pwrmiller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all users of constructs would have to know beforehand the keys in the context to expect, and use either
tryGetContextorgetContextto retrieve a specific key from context.This provides a mechanism to get the full context of a node in the construct tree, with overridable defaults.
The
getAllContextmethod allows users to retrieve all context. The interface forgetContextandtryGetContextremains unchanged.I have also fixed a small typo in the library.