fix: Link to events v2 url#588
Merged
omkhegde merged 5 commits intoaws-actions:masterfrom Jul 29, 2024
Merged
Conversation
Contributor
Author
|
This time with npm test locally tested PS: are you sure you want: "Send Notifications to Slack" to require approval? https://github.com/aws-actions/amazon-ecs-deploy-task-definition/actions/runs/10143607123 |
Contributor
Author
|
And fixed package test |
omkhegde
approved these changes
Jul 29, 2024
s3cube
approved these changes
Jul 29, 2024
kg-aws
approved these changes
Jul 29, 2024
karanbokil
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The url to check the events is using the v1, the v2 has been released since around Jan 2023 and isn't backward compatible. Just a Quality of Life thing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.