feat: add new parameters and tests to one-off task feature#593
Merged
amazreech merged 63 commits intoaws-actions:masterfrom Jul 30, 2024
Merged
feat: add new parameters and tests to one-off task feature#593amazreech merged 63 commits intoaws-actions:masterfrom
amazreech merged 63 commits intoaws-actions:masterfrom
Conversation
…s, updated runTask and updateEcsService functions to use new cluster names, and modified tests to accommodate new cluster creation"
… cluster command, added capacity provider strategy, and modified tests"
…o capacity provider strategy, task definition, and ECS service updates."
for action.yml
… a service proceeds that failed task
omkhegde
approved these changes
Jul 30, 2024
amazreech
requested changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #54 and #304 and #273
Description of changes: Added additional tests and parameter to #304 , this feature is known as a one-off task.
Description of Existing Tests
The ability to have a one off task run with default inputs
The ability to have a one off task run with desired settings
Checking when a task stops if it stops/fails properly
New implemented parameters and tests
Assign public IP feature for secure deployment
Additional tests for wait-for-task-stopped
The ability to have a one off task run and also a service
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.