Conversation
graebm
reviewed
Jul 10, 2023
graebm
approved these changes
Jul 10, 2023
| credential_provider (Optional[AwsCredentialsProvider]): Credentials providers source the | ||
| :class:`~awscrt.auth.AwsCredentials` needed to sign an authenticated AWS request. | ||
| signing_config (Optional[AwsSigningConfig]): | ||
| Configuration for signing of the client. Use `create_default_s3_signing_config` to create the default config. |
Contributor
There was a problem hiding this comment.
trivial: do a link
Suggested change
| Configuration for signing of the client. Use `create_default_s3_signing_config` to create the default config. | |
| Configuration for signing of the client. Use :func:`create_default_s3_signing_config()` to create the default config. |
you can check how the docs look locally by running ./scripts/make-docs.py
| :class:`~awscrt.auth.AwsCredentials` needed to sign an authenticated AWS request, for this request only. | ||
| If None is provided, the credential provider in the client will be used. | ||
| signing_config (Optional[AwsSigningConfig]): | ||
| Configuration for signing of the request to override the configuration from client. Use `create_default_s3_signing_config` to create the default config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.