fix: correct AxiosInstance call signature for typed responses#7328
Merged
jasonsaayman merged 2 commits intoaxios:v0.xfrom Feb 23, 2026
Merged
fix: correct AxiosInstance call signature for typed responses#7328jasonsaayman merged 2 commits intoaxios:v0.xfrom
jasonsaayman merged 2 commits intoaxios:v0.xfrom
Conversation
Member
Contributor
|
@jasonsaayman I have started the AI code review. It will take a few minutes to complete. |
|
Hi @jasonsaayman, what changes are needed on this PR? We're hitting this issue and currently stuck on 1.13.2 until this is merged. |
Member
|
sorry @jdpt0 i miss labeled im looking at this asap |
jasonsaayman
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7301
What
This PR fixes the AxiosInstance call signature to correctly type the generic response data.
How to verify
You can verify the fix locally by linking your modified axios package:
1.In your axios fork:
npm link2.In a separate test project:
npm link axios3.Write TypeScript code like:
Run TypeScript compilation:
npx tsc --noEmit