-
-
Notifications
You must be signed in to change notification settings - Fork 969
noSecrets False positive secret detection #8809
Copy link
Copy link
Labels
A-LinterArea: linterArea: linterL-JavaScriptLanguage: JavaScript and super languagesLanguage: JavaScript and super languagesS-Bug-confirmedStatus: report has been confirmed as a valid bugStatus: report has been confirmed as a valid bugS-Help-wantedStatus: you're familiar with the code base and want to help the projectStatus: you're familiar with the code base and want to help the project
Metadata
Metadata
Assignees
Labels
A-LinterArea: linterArea: linterL-JavaScriptLanguage: JavaScript and super languagesLanguage: JavaScript and super languagesS-Bug-confirmedStatus: report has been confirmed as a valid bugStatus: report has been confirmed as a valid bugS-Help-wantedStatus: you're familiar with the code base and want to help the projectStatus: you're familiar with the code base and want to help the project
Environment information
sprinkles.css.ts:
shorthands: { padding: ['paddingTop', 'paddingBottom', 'paddingLeft', 'paddingRight'], paddingX: ['paddingLeft', 'paddingRight'], paddingY: ['paddingTop', 'paddingBottom'], }, // Color properties const colorProperties = defineProperties({ properties: { color, backgroundColor: color, borderColor: color, }, shorthands: { bg: ['backgroundColor'], }, });paddingBottom,paddingRight,backgroundColorare detected as a potential secret. Typical usage of https://vanilla-extract.style/.Can't reproduce it in playground but here is a screenshot.
Rule name
lint/security/noSecrets
Playground link
https://biomejs.dev/playground/?quoteStyle=single&indentWidth=4&lintRules=all&code=YwBvAG4AcwB0ACAAcgBlAHMAcABvAG4AcwBpAHYAZQBQAHIAbwBwAGUAcgB0AGkAZQBzACAAPQAgAGQAZQBmAGkAbgBlAFAAcgBvAHAAZQByAHQAaQBlAHMAKAB7AAoAIAAgACAAIABkAGUAZgBhAHUAbAB0AEMAbwBuAGQAaQB0AGkAbwBuADoAIAAnAG0AbwBiAGkAbABlACcALAAKACAAIAAgACAAYwBvAG4AZABpAHQAaQBvAG4AcwA6ACAAewAKACAAIAAgACAAIAAgACAAIABtAG8AYgBpAGwAZQA6ACAAewB9ACwACgAgACAAIAAgACAAIAAgACAAdABhAGIAbABlAHQAOgAgAHsAIAAnAEAAbQBlAGQAaQBhACcAOgAgAG0AZQBkAGkAYQAuAHQAYQBiAGwAZQB0ACAAfQAsAAoAIAAgACAAIAAgACAAIAAgAGQAZQBzAGsAdABvAHAAOgAgAHsAIAAnAEAAbQBlAGQAaQBhACcAOgAgAG0AZQBkAGkAYQAuAGQAZQBzAGsAdABvAHAAIAB9ACwACgAgACAAIAAgAH0ALAAKACAAIAAgACAAcgBlAHMAcABvAG4AcwBpAHYAZQBBAHIAcgBhAHkAOgAgAFsAJwBtAG8AYgBpAGwAZQAnACwAIAAnAHQAYQBiAGwAZQB0ACcALAAgACcAZABlAHMAawB0AG8AcAAnAF0ALAAKACAAIAAgACAAcAByAG8AcABlAHIAdABpAGUAcwA6ACAAewAKACAAIAAgACAAIAAgACAAIABkAGkAcwBwAGwAYQB5ADoAIABbACcAbgBvAG4AZQAnACwAIAAnAGIAbABvAGMAawAnACwAIAAnAGYAbABlAHgAJwAsACAAJwBnAHIAaQBkACcALAAgACcAaQBuAGwAaQBuAGUAJwAsACAAJwBpAG4AbABpAG4AZQAtAGYAbABlAHgAJwBdACwACgAgACAAIAAgACAAIAAgACAAZgBsAGUAeABEAGkAcgBlAGMAdABpAG8AbgA6ACAAWwAnAHIAbwB3ACcALAAgACcAYwBvAGwAdQBtAG4AJwBdACwACgAgACAAIAAgACAAIAAgACAAYQBsAGkAZwBuAEkAdABlAG0AcwA6ACAAWwAnAHMAdAByAGUAdABjAGgAJwAsACAAJwBmAGwAZQB4AC0AcwB0AGEAcgB0ACcALAAgACcAYwBlAG4AdABlAHIAJwAsACAAJwBmAGwAZQB4AC0AZQBuAGQAJwBdACwACgAgACAAIAAgACAAIAAgACAAagB1AHMAdABpAGYAeQBDAG8AbgB0AGUAbgB0ADoAIABbACcAZgBsAGUAeAAtAHMAdABhAHIAdAAnACwAIAAnAGMAZQBuAHQAZQByACcALAAgACcAZgBsAGUAeAAtAGUAbgBkACcALAAgACcAcwBwAGEAYwBlAC0AYgBlAHQAdwBlAGUAbgAnAF0ALAAKACAAIAAgACAAIAAgACAAIABnAGEAcAA6ACAAcwBwAGEAYwBlACwACgAgACAAIAAgACAAIAAgACAAcABhAGQAZABpAG4AZwBUAG8AcAA6ACAAcwBwAGEAYwBlACwACgAgACAAIAAgACAAIAAgACAAcABhAGQAZABpAG4AZwBCAG8AdAB0AG8AbQA6ACAAcwBwAGEAYwBlACwACgAgACAAIAAgACAAIAAgACAAcABhAGQAZABpAG4AZwBMAGUAZgB0ADoAIABzAHAAYQBjAGUALAAKACAAIAAgACAAIAAgACAAIABwAGEAZABkAGkAbgBnAFIAaQBnAGgAdAA6ACAAcwBwAGEAYwBlACwACgAgACAAIAAgACAAIAAgACAAbQBhAHIAZwBpAG4AVABvAHAAOgAgAHMAcABhAGMAZQAsAAoAIAAgACAAIAAgACAAIAAgAG0AYQByAGcAaQBuAEIAbwB0AHQAbwBtADoAIABzAHAAYQBjAGUALAAKACAAIAAgACAAIAAgACAAIAB0AGUAeAB0AEEAbABpAGcAbgA6ACAAWwAnAGwAZQBmAHQAJwAsACAAJwBjAGUAbgB0AGUAcgAnACwAIAAnAHIAaQBnAGgAdAAnAF0ALAAKACAAIAAgACAAfQAsAAoAIAAgACAAIABzAGgAbwByAHQAaABhAG4AZABzADoAIAB7AAoAIAAgACAAIAAgACAAIAAgAHAAYQBkAGQAaQBuAGcAOgAgAFsAJwBwAGEAZABkAGkAbgBnAFQAbwBwACcALAAgACcAcABhAGQAZABpAG4AZwBCAG8AdAB0AG8AbQAnACwAIAAnAHAAYQBkAGQAaQBuAGcATABlAGYAdAAnACwAIAAnAHAAYQBkAGQAaQBuAGcAUgBpAGcAaAB0ACcAXQAsAAoAIAAgACAAIAAgACAAIAAgAHAAYQBkAGQAaQBuAGcAWAA6ACAAWwAnAHAAYQBkAGQAaQBuAGcATABlAGYAdAAnACwAIAAnAHAAYQBkAGQAaQBuAGcAUgBpAGcAaAB0ACcAXQAsAAoAIAAgACAAIAAgACAAIAAgAHAAYQBkAGQAaQBuAGcAWQA6ACAAWwAnAHAAYQBkAGQAaQBuAGcAVABvAHAAJwAsACAAJwBwAGEAZABkAGkAbgBnAEIAbwB0AHQAbwBtACcAXQAsAAoAIAAgACAAIAB9ACwACgB9ACkAOwA%3D
Expected result
It shouldn't detect these as secrets.
Code of Conduct