Conversation
siiky
reviewed
Oct 22, 2021
Comment on lines
+606
to
+609
| "alphabet": "base45", | ||
| "hex": "05e9b0213ba6e5e9fc62aa2906", | ||
| "string": " /+F5SZ6LLW+ " | ||
| }, |
There was a problem hiding this comment.
If I understood correctly, hex is (the hexadecimal of) the message to be encoded, and string is the encoded message?
Member
Author
There was a problem hiding this comment.
Yes. So encode(Buffer.from(hex, "hex")) should output string and decode(string) should output the same Buffer as Buffer.from(hex, "hex")
There was a problem hiding this comment.
Right, then everything LGTM! I also tried the one message we had failing and it worked, as expected. Thanks for taking care of it so quickly!
siiky
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
To be released in patch.