Merged
Conversation
| @@ -1,4 +1,4 @@ | |||
| // Generated by dart2js (NullSafetyMode.sound, csp, intern-composite-values), the Dart to JavaScript compiler version: 3.8.0-91.0.dev. | |||
| // Generated by dart2js (, csp, intern-composite-values), the Dart to JavaScript compiler version: 3.9.4. | |||
Contributor
Author
There was a problem hiding this comment.
Regenerated with dart 3.9.4 because thats what I happened to have on my computer at the time
I'm happy to revert this back to dart 3.8.0, or bump this up to 3.11.2 if thats preferred
Member
There was a problem hiding this comment.
I think latest stable is ideal here. @athomas should comment.
Contributor
Author
There was a problem hiding this comment.
Updated!
Closed
athomas
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the fix for the issue I reported here: #173
@vercel/nccas a dev dependency for easiernpm run distexecution"engines"for node v24 to ensure future usage of node v24Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.