feat!: move AST traversal into SourceCode#18167
Merged
mdjermanovic merged 11 commits intomainfrom Mar 21, 2024
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Linterand intoSourceCode#traverse().no-useless-returns,constructor-super, andno-this-before-superto they still work. These rules were also tested against v8.57.0 to ensure that such changes would be backwards compatible.Refs #16999
Is there anything you'd like reviewers to focus on?
I deviated from the RFC in how I represented the traversal steps. I realized while implementing that relying on
typeandphaseas string comparisons would be a big performance hit, so I added thekindproperty as a number (keepingtypefor easier debugging, though not sure if that's needed) and switchedphaseto a number. That saves us a lot of string comparisons during traversal.