-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Open
Labels
Description
Expected Behavior
I can add podAnnotations in feast-feature-server helm chart
Current Behavior
If I add any podAnnotations to values.yaml I get an error durning installation:
Error: INSTALLATION FAILED: feast-feature-server/templates/deployment.yaml:17:22
executing "feast-feature-server/templates/deployment.yaml" at <.Values.metrics.enabled>:
nil pointer evaluating interface {}.metrics
Steps to reproduce
Get helm chart:
helm pull feast/feast-feature-server --version 0.61.0 --untar
add any annotation in values.yaml like:
podAnnotations:
foo: "bar"
Install the chart:
$ helm install feast-feature-server ./
Error: INSTALLATION FAILED: feast-feature-server/templates/deployment.yaml:17:22
executing "feast-feature-server/templates/deployment.yaml" at <.Values.metrics.enabled>:
nil pointer evaluating interface {}.metrics
Specifications
- Version: 0.60.0, 0.61.0
- Platform: MaOS arm64
- Subsystem:
Possible Solution
Change .Values.metrics.enabled to $.Values.metrics.enabled to fix context in templates/deployment.yaml eg.
metadata:
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- if $.Values.metrics.enabled }}
instrumentation.opentelemetry.io/inject-python: "true"
{{- end }}
{{- end }}
Reactions are currently unavailable