Skip to content

[vscode] Display non 200 error nicely#9785

Merged
fredzqm merged 11 commits intomainfrom
fz/vscode-non-200-error
Jan 22, 2026
Merged

[vscode] Display non 200 error nicely#9785
fredzqm merged 11 commits intomainfrom
fz/vscode-non-200-error

Conversation

@fredzqm
Copy link
Copy Markdown
Contributor

@fredzqm fredzqm commented Jan 22, 2026

  • Inlined DataConnectExecutionResultsApp.tsx into the main component
  • Move the error handling logic to execution.ts and pass structured errors to UI components.

Permission Denied

Emulator

Screenshot 2026-01-22 at 8 26 56 AM

Prod

Screenshot 2026-01-22 at 8 32 18 AM

Service Not Found

Prod
Screenshot 2026-01-22 at 8 28 31 AM

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the error reporting mechanism within the VSCode extension for Data Connect GraphQL executions. It introduces a refined data structure to differentiate between HTTP-level response errors and GraphQL-specific errors, ensuring that users receive more precise and actionable feedback when queries fail. The changes also streamline the internal handling of execution results by centralizing error processing and cleaning up unnecessary dependencies.

Highlights

  • Refactored Error Handling: Introduced a new ExecutionResults interface to clearly distinguish between HTTP response errors (respErr) and GraphQL errors (gqlErrors) within a successful HTTP response, providing a more structured approach to error reporting.
  • Improved Error Display in UI: The Data Connect execution results UI has been updated to explicitly render separate sections for HTTP response errors and GraphQL errors, offering users clearer and more precise feedback on query failures.
  • Decoupled Error Processing: The DataConnectService now returns raw HTTP responses, and the logic for processing and structuring these responses, including error interpretation, has been centralized in the execution.ts file.
  • Dependency Cleanup: Several unused or transitive dependencies related to browser automation (e.g., puppeteer, chromium-bidi, zod) have been removed from package-lock.json, streamlining the project dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the handling and display of GraphQL execution results and errors, particularly improving how non-200 HTTP status codes are presented to the user. The introduction of the ExecutionResults interface and the updated error parsing logic in execution.ts provide a more granular way to distinguish between GraphQL-specific errors and underlying HTTP response issues. The UI component has been updated to reflect these changes, ensuring a better user experience when encountering errors.

Comment thread firebase-vscode/src/data-connect/execution/execution.ts Outdated
Comment thread src/dataconnect/types.ts
@fredzqm fredzqm requested a review from hlshen January 22, 2026 16:42
Copy link
Copy Markdown
Contributor

@hlshen hlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up code along the way! Looks great

@fredzqm fredzqm enabled auto-merge (squash) January 22, 2026 19:27
@fredzqm fredzqm merged commit c5d95c1 into main Jan 22, 2026
47 checks passed
@fredzqm fredzqm deleted the fz/vscode-non-200-error branch January 22, 2026 19:38
@hlshen hlshen mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants