fix: Constrain types of ai_track decorator#4745
Merged
alexander-alderman-webb merged 1 commit intomasterfrom Sep 3, 2025
Merged
fix: Constrain types of ai_track decorator#4745alexander-alderman-webb merged 1 commit intomasterfrom
alexander-alderman-webb merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4745 +/- ##
==========================================
- Coverage 84.88% 84.85% -0.03%
==========================================
Files 156 156
Lines 16115 16115
Branches 2741 2741
==========================================
- Hits 13679 13675 -4
- Misses 1650 1652 +2
- Partials 786 788 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code snippet now fails mypy: #4663 (comment)
I followed how other functions in the SDK are typed. For example, other wrappers have the signature
(F) -> Ffor a type variableF, although here the function can be async as well.Closes #4663